forked from NVIDIA/dcgm-exporter
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathMakefile
More file actions
242 lines (207 loc) · 8.49 KB
/
Makefile
File metadata and controls
242 lines (207 loc) · 8.49 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
# Copyright (c) 2021, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
include hack/VERSION
REGISTRY ?= nvidia
GO ?= go
MKDIR ?= mkdir
GOLANGCILINT_TIMEOUT ?= 10m
IMAGE_TAG ?= ""
DCGM_VERSION := $(NEW_DCGM_VERSION)
GOLANG_VERSION := 1.24.12
VERSION := $(NEW_EXPORTER_VERSION)
FULL_VERSION := $(DCGM_VERSION)-$(VERSION)
OUTPUT := type=oci,dest=/dev/null
PLATFORMS := linux/amd64,linux/arm64
DOCKERCMD := docker --debug buildx build
MODULE := github.com/NVIDIA/dcgm-exporter
.PHONY: all binary install check-format local
all: ubuntu22.04 ubi9 distroless
binary:
cd cmd/dcgm-exporter; $(GO) build -trimpath -ldflags "-X main.BuildVersion=${DCGM_VERSION}-${VERSION}"
test-main: generate
$(GO) test ./... -short
install: binary
install -m 755 cmd/dcgm-exporter/dcgm-exporter /usr/bin/dcgm-exporter
install -m 644 -D ./etc/default-counters.csv /etc/dcgm-exporter/default-counters.csv
check-format:
test $$(gofmt -l pkg | tee /dev/stderr | wc -l) -eq 0
test $$(gofmt -l cmd | tee /dev/stderr | wc -l) -eq 0
push:
$(MAKE) ubuntu22.04 OUTPUT=type=registry
$(MAKE) ubi9 OUTPUT=type=registry
$(MAKE) distroless OUTPUT=type=registry
local:
ifeq ($(shell uname -p),aarch64)
$(MAKE) PLATFORMS=linux/arm64 OUTPUT=type=docker DOCKERCMD='docker build'
else
$(MAKE) PLATFORMS=linux/amd64 OUTPUT=type=docker DOCKERCMD='docker build'
endif
ubi%: DOCKERFILE = docker/Dockerfile
ubi%: BUILD_TARGET = runtime-ubi
ubi%: --docker-build-%
@
ubi9: BASE_IMAGE = nvcr.io/nvidia/cuda:13.1.1-base-ubi9
ubi9: IMAGE_TAG = ubi9
ubuntu%: DOCKERFILE = docker/Dockerfile
ubuntu%: BUILD_TARGET = runtime-ubuntu
ubuntu%: --docker-build-%
@
ubuntu22.04: BASE_IMAGE = nvcr.io/nvidia/cuda:13.1.1-base-ubuntu22.04
ubuntu22.04: IMAGE_TAG = ubuntu22.04
distroless: DOCKERFILE = docker/Dockerfile
distroless: BUILD_TARGET = runtime-distroless
distroless: IMAGE_TAG = distroless
distroless: --docker-build-distroless
--docker-build-%:
@echo "Building for $@ with target $(BUILD_TARGET)"
docker buildx inspect
DOCKER_BUILDKIT=1 \
$(DOCKERCMD) --pull \
--output $(OUTPUT) \
--progress=plain \
--no-cache \
--platform $(PLATFORMS) \
$(if $(BUILD_TARGET),--target $(BUILD_TARGET)) \
--build-arg BASEIMAGE="$(BASE_IMAGE)" \
--build-arg "GOLANG_VERSION=$(GOLANG_VERSION)" \
--build-arg "DCGM_VERSION=$(DCGM_VERSION)" \
--build-arg "VERSION=$(VERSION)" \
--tag $(REGISTRY)/dcgm-exporter:$(FULL_VERSION)$(if $(IMAGE_TAG),-$(IMAGE_TAG)) \
--file $(DOCKERFILE) .
.PHONY: packages package-arm64 package-amd64
packages: package-amd64 package-arm64
package-arm64:
$(MAKE) package-build PLATFORMS=linux/arm64
package-amd64:
$(MAKE) package-build PLATFORMS=linux/amd64
package-build: IMAGE_TAG = ubuntu22.04
package-build:
ARCH=`echo $(PLATFORMS) | cut -d'/' -f2)`; \
if [ "$$ARCH" = "amd64" ]; then \
ARCH="x86-64"; \
fi; \
if [ "$$ARCH" = "arm64" ]; then \
ARCH="sbsa"; \
fi; \
export DIST_NAME="dcgm_exporter-linux-$$ARCH-$(VERSION)"; \
export COMPONENT_NAME="dcgm_exporter"; \
$(MAKE) ubuntu22.04 OUTPUT=type=docker PLATFORMS=$(PLATFORMS) && \
$(MKDIR) -p /tmp/$$DIST_NAME/$$COMPONENT_NAME && \
$(MKDIR) -p /tmp/$$DIST_NAME/$$COMPONENT_NAME/usr/bin && \
$(MKDIR) -p /tmp/$$DIST_NAME/$$COMPONENT_NAME/etc/dcgm-exporter && \
I=`docker create $(REGISTRY)/dcgm-exporter:$(FULL_VERSION)-$(IMAGE_TAG)` && \
docker cp $$I:/usr/bin/dcgm-exporter /tmp/$$DIST_NAME/$$COMPONENT_NAME/usr/bin/ && \
docker cp $$I:/etc/dcgm-exporter /tmp/$$DIST_NAME/$$COMPONENT_NAME/etc/ && \
cp ./LICENSE /tmp/$$DIST_NAME/$$COMPONENT_NAME && \
mkdir -p /tmp/$$DIST_NAME/$$COMPONENT_NAME/lib/systemd/system/ && \
cp ./packaging/config-files/systemd/nvidia-dcgm-exporter.service \
/tmp/$$DIST_NAME/$$COMPONENT_NAME/lib/systemd/system/nvidia-dcgm-exporter.service && \
docker rm -f $$I && \
$(MKDIR) -p $(CURDIR)/dist && \
cd "/tmp/$$DIST_NAME" && tar -czf $(CURDIR)/dist/$$DIST_NAME.tar.gz `ls -A` && \
rm -rf "/tmp/$$DIST_NAME";
.PHONY: integration
test-integration: generate
go test -race -count=1 -timeout 5m -v $(TEST_ARGS) ./tests/integration/
test-coverage:
@echo "Running unit tests..."
gotestsum --format testname -- \
$$(go list ./... | grep -v "/tests/e2e/") \
-count=1 -timeout 5m \
-covermode=count \
-coverprofile=unit_coverage.out \
--short
@echo "Running integration tests..."
gotestsum --format testname -- \
./internal/pkg/integration_test/... \
-count=1 -timeout 5m \
-covermode=count \
-coverpkg=./internal/pkg/... \
-coverprofile=integration_coverage.out \
--short
@echo "Merging coverage profiles..."
gocovmerge unit_coverage.out integration_coverage.out > combined_coverage.out.tmp
cat combined_coverage.out.tmp | grep -v "mock_" > tests.cov
rm combined_coverage.out.tmp integration_coverage.out unit_coverage.out
go tool cover -func=tests.cov
.PHONY: lint
lint:
GOOS=linux GOARCH=amd64 CGO_ENABLED=1 GOGC=50 \
golangci-lint run ./... --timeout $(GOLANGCILINT_TIMEOUT) --new-from-rev=HEAD~1 --concurrency=2
.PHONY: hadolint lint-dockerfiles
hadolint lint-dockerfiles: ## Lint Dockerfiles with hadolint
@echo "Linting Dockerfiles with hadolint..."
@if command -v hadolint > /dev/null 2>&1; then \
hadolint docker/Dockerfile.ubuntu docker/Dockerfile.ubi docker/Dockerfile.distroless; \
elif docker inspect hadolint/hadolint > /dev/null 2>&1; then \
docker run --rm -i -v "$(CURDIR)/.hadolint.yaml:/.config/hadolint.yaml" \
hadolint/hadolint < docker/Dockerfile.ubuntu && \
docker run --rm -i -v "$(CURDIR)/.hadolint.yaml:/.config/hadolint.yaml" \
hadolint/hadolint < docker/Dockerfile.ubi && \
docker run --rm -i -v "$(CURDIR)/.hadolint.yaml:/.config/hadolint.yaml" \
hadolint/hadolint < docker/Dockerfile.distroless; \
else \
echo "Error: hadolint not found. Install it or run: docker pull hadolint/hadolint"; \
exit 1; \
fi
@echo "✓ All Dockerfiles passed hadolint checks"
.PHONY: validate-modules
validate-modules:
@echo "- Verifying that the dependencies have expected content..."
go mod verify
@echo "- Checking for any unused/missing packages in go.mod..."
go mod tidy
@git diff --exit-code -- go.sum go.mod
.PHONY: validate
validate: validate-modules hadolint check-fmt ## Run all validation checks
@echo "✓ All validation checks passed"
.PHONY: tools
tools: ## Install required tools and utilities
curl -sSfL https://golangci-lint.run/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v2.8.0
go install golang.org/x/tools/cmd/goimports@v0.41.0
go install mvdan.cc/gofumpt@v0.9.2
go install github.com/wadey/gocovmerge@v0.0.0-20160331181800-b5bfa59ec0ad
go install gotest.tools/gotestsum@v1.13.0
fmt:
find . -name '*.go' | xargs gofumpt -l -w
goimports:
go list -f {{.Dir}} $(MODULE)/... \
| xargs goimports -local $(MODULE) -w
check-fmt:
@echo "Checking code formatting. Any listed files don't match goimports:"
! (find . -iname "*.go" \
| xargs goimports -l -local $(MODULE) | grep .)
.PHONY: e2e-test
e2e-test:
cd tests/e2e && make e2e-test
# Command for in-place substitution
SED_CMD := sed -i$(shell uname -s | grep -q Darwin && echo " ''")
# Create list of paths to YAML, README.md, and Makefile files
FILE_PATHS := $(shell find . -type f \( -name "*.yaml" -o -name "README.md" -o -name "Makefile" \))
# Replace the old version with the new version in specified files
update-version:
@echo "Updating DCGM version in files from $(OLD_DCGM_VERSION) to $(NEW_DCGM_VERSION)..."
@$(foreach file,$(FILE_PATHS),$(SED_CMD) "s/$(OLD_DCGM_VERSION)/$(NEW_DCGM_VERSION)/g" $(file);)
@echo "Updating DCGM Exporter version in files from $(OLD_EXPORTER_VERSION) to $(NEW_EXPORTER_VERSION)..."
@$(foreach file,$(FILE_PATHS),$(SED_CMD) "s/$(OLD_EXPORTER_VERSION)/$(NEW_EXPORTER_VERSION)/g" $(file);)
# Update DCGM and DCGM Exporter versions
update-versions: update-version
.PHONY: generate
# Generate code (Mocks)
generate:
go generate ./...
.PHONY: test-images
test-images: ## Run Docker image validation tests (requires local images built with 'make local')
@echo "Running Docker image tests..."
cd tests/docker && $(MAKE) docker-test