From 32954b071db40881551b781b7ce72524968bb355 Mon Sep 17 00:00:00 2001 From: Kofi Asare Date: Sun, 5 Jun 2022 00:57:27 +0000 Subject: [PATCH] Address the Redis 5.0.0 deprecation warning Pipelining commands on a Redis instance are deprecated and will be removed in Redis 5.0.0. redis.pipelined do redis.get("key") end should be replaced by redis.pipelined do |pipeline| pipeline.get("key") end --- lib/pallets/backends/redis.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/pallets/backends/redis.rb b/lib/pallets/backends/redis.rb index 60bb63d..da37ab3 100644 --- a/lib/pallets/backends/redis.rb +++ b/lib/pallets/backends/redis.rb @@ -96,15 +96,15 @@ def reschedule_all(earlier_than) def run_workflow(wfid, jobs, jobmasks, context_buffer) @pool.execute do |client| - client.multi do - jobmasks.each { |jid, jobmask| client.zadd(JOBMASK_KEY % jid, jobmask) } - client.sadd(JOBMASKS_KEY % wfid, jobmasks.map { |jid, _| JOBMASK_KEY % jid }) unless jobmasks.empty? - client.evalsha( + client.multi do |pipeline| + jobmasks.each { |jid, jobmask| pipeline.zadd(JOBMASK_KEY % jid, jobmask) } + pipeline.sadd(JOBMASKS_KEY % wfid, jobmasks.map { |jid, _| JOBMASK_KEY % jid }) unless jobmasks.empty? + pipeline.evalsha( @scripts['run_workflow'], [WORKFLOW_QUEUE_KEY % wfid, QUEUE_KEY, REMAINING_KEY % wfid], jobs ) - client.hmset(CONTEXT_KEY % wfid, *context_buffer.to_a) unless context_buffer.empty? + pipeline.hmset(CONTEXT_KEY % wfid, *context_buffer.to_a) unless context_buffer.empty? end end end