From d100685cbbd126a9d029de7dd3d95ec2b49ebb4d Mon Sep 17 00:00:00 2001 From: konard Date: Thu, 8 Jan 2026 19:03:36 +0100 Subject: [PATCH 1/4] Initial commit with task details Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: https://github.com/link-foundation/start/issues/73 --- CLAUDE.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 CLAUDE.md diff --git a/CLAUDE.md b/CLAUDE.md new file mode 100644 index 0000000..a442e8f --- /dev/null +++ b/CLAUDE.md @@ -0,0 +1,5 @@ +Issue to solve: https://github.com/link-foundation/start/issues/73 +Your prepared branch: issue-73-c42828279fb5 +Your prepared working directory: /tmp/gh-issue-solver-1767895415502 + +Proceed. From 47490516ad0f28710a743a077d0ccee4f21126b7 Mon Sep 17 00:00:00 2001 From: konard Date: Thu, 8 Jan 2026 19:09:25 +0100 Subject: [PATCH 2/4] fix: Remove empty line after virtual command to maintain visual continuity MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fixed visual continuity break in docker pull output - Removed empty line between timeline marker (`ā”‚`) and virtual command line (`$ docker pull`) - Output now flows continuously from timeline marker to command to output - Applies to both JavaScript (js/src/lib/docker-utils.js) and Rust (rust/src/lib/isolation.rs) implementations - Added test script to verify output format (experiments/test-docker-pull-output.js) - Added changelog entries for both implementations Fixes #73 šŸ¤– Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 --- experiments/test-docker-pull-output.js | 35 +++++++++++++++++++++++ js/.changeset/fix-visual-continuity-73.md | 12 ++++++++ js/src/lib/docker-utils.js | 1 - rust/changelog.d/73.md | 8 ++++++ rust/src/lib/isolation.rs | 1 - 5 files changed, 55 insertions(+), 2 deletions(-) create mode 100644 experiments/test-docker-pull-output.js create mode 100644 js/.changeset/fix-visual-continuity-73.md create mode 100644 rust/changelog.d/73.md diff --git a/experiments/test-docker-pull-output.js b/experiments/test-docker-pull-output.js new file mode 100644 index 0000000..a2d5c3c --- /dev/null +++ b/experiments/test-docker-pull-output.js @@ -0,0 +1,35 @@ +#!/usr/bin/env node +/** + * Test script to verify docker pull output format + * This test verifies that there is no empty line between + * the timeline marker and the virtual command line + */ + +const { + createVirtualCommandBlock, + createVirtualCommandResult, + createTimelineSeparator, +} = require('../js/src/lib/output-blocks'); + +console.log('Testing virtual command output format...\n'); + +// Simulate what dockerPullImage does +const image = 'alpine:latest'; + +// Print the virtual command line (should NOT have empty line after) +const commandBlock = createVirtualCommandBlock(`docker pull ${image}`); +console.log(commandBlock); + +// Expected: next line should be docker pull output, NOT an empty line +console.log('latest: Pulling from library/alpine'); +console.log('f6b4fb944634: Pull complete'); +console.log('Digest: sha256:865b95f46d98cf867a156fe4a135ad3fe50d2056aa3f25ed31662dff6da4eb62'); +console.log('Status: Downloaded newer image for alpine:latest'); +console.log('docker.io/library/alpine:latest'); + +// Print result marker and separator +console.log(); +console.log(createVirtualCommandResult(true)); +console.log(createTimelineSeparator()); + +console.log('\nāœ“ Test complete - verify no empty line after "$ docker pull alpine:latest"'); diff --git a/js/.changeset/fix-visual-continuity-73.md b/js/.changeset/fix-visual-continuity-73.md new file mode 100644 index 0000000..f1a9ebe --- /dev/null +++ b/js/.changeset/fix-visual-continuity-73.md @@ -0,0 +1,12 @@ +--- +"start-command": patch +--- + +fix: Remove empty line after virtual command to maintain visual continuity + +- Fixed visual continuity break in docker pull output +- Removed empty line between timeline marker (`ā”‚`) and virtual command line (`$ docker pull`) +- Output now flows continuously from timeline marker to command to output +- Applies to all virtual command blocks (currently docker pull operations) + +Fixes #73 diff --git a/js/src/lib/docker-utils.js b/js/src/lib/docker-utils.js index e9957e8..5768966 100644 --- a/js/src/lib/docker-utils.js +++ b/js/src/lib/docker-utils.js @@ -117,7 +117,6 @@ function dockerPullImage(image) { // Print the virtual command line console.log(createVirtualCommandBlock(`docker pull ${image}`)); - console.log(); let output = ''; let success = false; diff --git a/rust/changelog.d/73.md b/rust/changelog.d/73.md new file mode 100644 index 0000000..faf95d8 --- /dev/null +++ b/rust/changelog.d/73.md @@ -0,0 +1,8 @@ +fix: Remove empty line after virtual command to maintain visual continuity + +- Fixed visual continuity break in docker pull output +- Removed empty line between timeline marker (`ā”‚`) and virtual command line (`$ docker pull`) +- Output now flows continuously from timeline marker to command to output +- Applies to all virtual command blocks (currently docker pull operations) + +Fixes #73 diff --git a/rust/src/lib/isolation.rs b/rust/src/lib/isolation.rs index 8495c4f..5fbb808 100644 --- a/rust/src/lib/isolation.rs +++ b/rust/src/lib/isolation.rs @@ -488,7 +488,6 @@ pub fn docker_pull_image(image: &str) -> (bool, String) { "{}", crate::output_blocks::create_virtual_command_block(&format!("docker pull {}", image)) ); - println!(); let mut child = match Command::new("docker") .args(["pull", image]) From 03063c37377f31f6b02deba97ef826a1163ca24f Mon Sep 17 00:00:00 2001 From: konard Date: Thu, 8 Jan 2026 19:12:47 +0100 Subject: [PATCH 3/4] chore: Format changeset file with prettier --- js/.changeset/fix-visual-continuity-73.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/.changeset/fix-visual-continuity-73.md b/js/.changeset/fix-visual-continuity-73.md index f1a9ebe..ed08503 100644 --- a/js/.changeset/fix-visual-continuity-73.md +++ b/js/.changeset/fix-visual-continuity-73.md @@ -1,5 +1,5 @@ --- -"start-command": patch +'start-command': patch --- fix: Remove empty line after virtual command to maintain visual continuity From 6d75953ceee2d84bf6198196f69070091b4625ef Mon Sep 17 00:00:00 2001 From: konard Date: Thu, 8 Jan 2026 19:15:39 +0100 Subject: [PATCH 4/4] Revert "Initial commit with task details" This reverts commit d100685cbbd126a9d029de7dd3d95ec2b49ebb4d. --- CLAUDE.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 CLAUDE.md diff --git a/CLAUDE.md b/CLAUDE.md deleted file mode 100644 index a442e8f..0000000 --- a/CLAUDE.md +++ /dev/null @@ -1,5 +0,0 @@ -Issue to solve: https://github.com/link-foundation/start/issues/73 -Your prepared branch: issue-73-c42828279fb5 -Your prepared working directory: /tmp/gh-issue-solver-1767895415502 - -Proceed.