macOS Support / Debugging help?

[paulreimer]

Love this feature + your other plugin repos using it. Now that I've enabled this on my work computers (Linux), I really wish I could use it on my home laptop (macOS).

I think macOS is close enough to Linux that the same approach is possible, but I'm not sure how to accomplish it exactly. I think I have found the replacement for LD_PRELOAD:

export DYLD_INSERT_LIBRARIES=</path/to/librl_custom_function.dylib>
export DYLD_FORCE_FLAT_NAMESPACE=1

I also modified src/lib.rs to run dlopen(b"libreadline.dylib\0", ... (dylib instead of so)

.inputrc is also respected on macOS; again using .dylib extension instead of .so (and attempting to load using plugins rl_custom_isearch + fzf-tab-completion/readline as described in their repos).

When I run a command with dtruss/dtrace (the macOS equivalent of strace), I can see that librl_custom_function.dylib gets loaded, but NOT the function dylibs in .inputrc (e.g. librl_custom_complete.dylib, librl_custom_isearch.dylib are not loaded or even mentioned in the syscall trace).

So now I wonder about the $include function <fname> <lib path> syntax for .inputrc, which I cannot find documented anywhere. Can you explain a bit more about this part specifically (how you figured it out for Linux), and/or hazard a guess on making better progress with macOS?

[paulreimer]

I see that this repo actually adds the support for the $include function syntax.

I started printf debugging the rust code and found the area that is not working:

rl_parse_and_bind only receives the string "tab: complete" (not sure where it gets this from).

However, if I add the plugins via hard-coded paths in rl_parse_and_bind, it all works!

readline::tilde_expand("~/Development/rust/fzf-tab-completion/readline/target/release/librl_custom_complete.dylib").and_then(|s| add_function("rl_custom_complete", &s));
readline::tilde_expand("~/Development/rust/rl_custom_isearch/target/release/librl_custom_isearch.dylib").and_then(|s| add_function("rl_custom_isearch", &s));

So I suppose the issue is with rl_parse_and_bind.

[paulreimer]

After some more inspection, I see in the syscalls that ~/.inputrc is opened+read. However, for most programs rl_parse_and_bind is not invoked. When I run python3, that is when I get the "tab: complete" getting parsed, which runs my hard-coded lines above which gets things "working".

Can you think of any reason why that might be? Perhaps the library injection or callback mapping is done too late; after the inputrc has already been parsed?

[lincheney]

hi, sorry i have not been paying attention to this repo :(
Did you ever figure this one out?

I have no idea how macOS works, but googling seems to suggest that macos does not actually use readline but libedit instead? If that is the case what you are running into is probably implementation differences between readline vs libedit.
What is meant to happen is that rl_parse_and_bind() is meant to be called by rl_read_init_file() which is responsible for reading the ~/.inputrc (see https://git.savannah.gnu.org/cgit/readline.git/tree/bind.c?h=readline-8.0#n1007) but libedit might be doing something different.

[dasl-]

@paulreimer did you get macOS support working with an M1 mac or an intel mac? I have an M1 mac, and I am unable to get it working. This is the error I get when creating a new terminal window:

dyld[15399]: terminating because inserted dylib '/Users/myusername/readline-hack/librl_custom_function.dylib' could not be loaded: tried: '/Users/myusername/readline-hack/librl_custom_function.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e'))

It is caused by this line in my .zshrc:

export DYLD_INSERT_LIBRARIES="/path/to/librl_custom_function.dylib"

I even tried compiling both rl_custom_function and rl_custom_isearch with an M1 specific target (as suggested here):

cargo build --release --target=aarch64-apple-darwin

But I got the same error when creating a new terminal window.

Note that when compiling with the --target=aarch64-apple-darwin, I believe the files will be located in ./target/aarch64-apple-darwin/release/... rather than ./target/release.

[paulreimer]

Unfortunately I wasn't able to get it working on my M1 Mac. I'm happy to try any suggestions!