Skip to content

Inline svg in LikeButtonV2 might cause performance issue #308

@williamchong

Description

@williamchong

e.g.

d="M75.1,69.7a1.09,1.09,0,0,1-.9-.4,1.24,1.24,0,0,1,.1-1.7,25.87,25.87,0,0,0,5.2-5.9,4.41,4.41,0,0,1,4.3-2.4,1.22,1.22,0,1,1-.4,2.4,2.11,2.11,0,0,0-1.9,1.2,29.54,29.54,0,0,1-5.7,6.6,1.45,1.45,0,0,1-.7.2M54.6,90.1a1.09,1.09,0,0,1-.9-.4,1.16,1.16,0,0,1,.2-1.7,29.17,29.17,0,0,1,4.5-3,1.19,1.19,0,1,1,1.1,2.1,35.24,35.24,0,0,0-4,2.7,1.9,1.9,0,0,1-.9.3M85.2,78.7c.5.4,1,.3,1.6-.2a45,45,0,0,0,8.5-11.3,1.12,1.12,0,0,1,1.4-.7c.7.3.7,1.4.1,2.7a44,44,0,0,1-8.3,11.6,1,1,0,0,0,0,1.4c.4.4,1,.3,1.6-.3a48.69,48.69,0,0,0,5.2-6,1.13,1.13,0,0,1,1.2-.6c.6.1.7.7.5,1.3-.3,1.1-3.4,5.1-4.6,6.4-3.3,3.7-6.6,5.7-13,8.9-2.2,1.1-3.9,2.2-4.9,3.9-.9,1.5-1.2,2-1.3,2.2a1.42,1.42,0,0,0,.7,2,1.27,1.27,0,0,0,.6.1,1.51,1.51,0,0,0,1.4-.9l1.1-2a8.74,8.74,0,0,1,3.7-3.3,37.77,37.77,0,0,0,12.7-8.8A42.16,42.16,0,0,0,98,78.8c1.8-3,.8-5.5-.8-5.9a.19.19,0,0,1-.1-.3,16,16,0,0,0,2-4.7c.3-1.5-.1-3.4-2.2-3.9-.1,0-.2-.1-.2-.3.1-.5.3-1.1.4-1.5a3.38,3.38,0,0,0-2.4-4.1,3.7,3.7,0,0,0-2.9.6.3.3,0,0,1-.4,0,2,2,0,0,0-1.6-.7,3.69,3.69,0,0,0-3.6,2.4,24.75,24.75,0,0,1-4.7,6.7,51.91,51.91,0,0,1-9,7.6c-.4.3-1,.2-.9-.3.1-.9,1.1-6.8,1.2-8.6.3-2.8-1.3-4.1-3-4.4-1.4-.2-3.6.2-4.8,3.4a82.33,82.33,0,0,0-3.4,10,29.52,29.52,0,0,0-.2,12.3,1.08,1.08,0,0,1-.2.8c-.9,1.5-2.3,3.6-3.1,5.3a1.43,1.43,0,0,0,.6,1.9,1.85,1.85,0,0,0,.7.2,1.51,1.51,0,0,0,1.4-.9c.5-1,1.4-2.8,1.8-3.5a20.83,20.83,0,0,0,1.2-2.7,3.71,3.71,0,0,0,0-2.4,23.82,23.82,0,0,1,.2-9.9,96.1,96.1,0,0,1,3.6-11.1c.4-.9.9-1.2,1.4-1.1s1.5.3,1.2,2.1c-.5,3.3-1.2,7.4-1.4,8.8-.1.7-.2,2.3,1,3,1,.6,2.1.3,3.3-.5a59.55,59.55,0,0,0,10.3-8.7,21.65,21.65,0,0,0,4.8-7.3,1.4,1.4,0,0,1,1.6-.7c.3.1.7.5.4,1.5-.7,2.3-3.5,7.4-8.9,12.3a1,1,0,0,0-.2,1.5,1.07,1.07,0,0,0,1.5,0A35.09,35.09,0,0,0,91.5,64a25.54,25.54,0,0,0,1.1-2.7,1.38,1.38,0,0,1,1.3-1c.6.1,1,.7.8,1.7a23.94,23.94,0,0,1-1.3,3.7A51.66,51.66,0,0,1,85,77.1a1.38,1.38,0,0,0,.2,1.6m-22-16.4a.51.51,0,0,0,.1-.5c-.3-.8-1.8-4.3-2.1-5-.2-.3-.4-.4-.7-.3a6.29,6.29,0,0,0-1.5,1,6,6,0,0,0-1.2,1.3.53.53,0,0,0,.2.7,53,53,0,0,0,4.7,2.8.33.33,0,0,0,.5,0Zm-1.3,2.3c0-.2-.3-.3-.4-.3-.9-.2-4.6-.7-5.4-.8-.4,0-.6.2-.6.4a6.05,6.05,0,0,0,.1,1.8,5.85,5.85,0,0,0,.5,1.7.48.48,0,0,0,.7.2c.7-.3,4.1-2.1,4.8-2.6.1,0,.3-.1.3-.4ZM90.1,93c-.2,0-.3.2-.4.4-.3.8-1.2,4.5-1.4,5.3a.53.53,0,0,0,.4.7,8.16,8.16,0,0,0,1.8.1,5.94,5.94,0,0,0,1.8-.3c.3-.1.4-.3.3-.7a31.15,31.15,0,0,0-2.1-5c0-.3-.1-.5-.4-.5Zm2.2-1.7a.44.44,0,0,0,.1.5,46.83,46.83,0,0,0,3.8,3.9.52.52,0,0,0,.8,0,5.4,5.4,0,0,0,1-1.5,12.83,12.83,0,0,0,.7-1.6c0-.3-.1-.5-.5-.6-.8-.2-4.5-.8-5.4-.9-.2,0-.4,0-.5.2Z"

d="M80,65.38l2.62,5.3a2.27,2.27,0,0,0,1.69,1.23l5.85.85a2.25,2.25,0,0,1,1.25,3.84l-4.23,4.12a2.24,2.24,0,0,0-.65,2l1,5.83a2.25,2.25,0,0,1-3.27,2.37L79,88.16a2.27,2.27,0,0,0-2.09,0l-5.23,2.75a2.25,2.25,0,0,1-3.27-2.37l1-5.83a2.24,2.24,0,0,0-.65-2L64.51,76.6a2.25,2.25,0,0,1,1.25-3.84l5.85-.85a2.27,2.27,0,0,0,1.69-1.23l2.62-5.3A2.25,2.25,0,0,1,80,65.38Z"

Incline SVG like this makes the page code huge and CPU time would be spent onto parsing the huge payload, blocking the page from interactive. We should consider splitting the svg code or this component into separated files to reduce blocking.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions