Skip to content

Commit 10438b6

Browse files
author
Clawd
committed
ci: remove test jobs (just checked module loads)
Simplifies workflow - build artifacts are the deliverable
1 parent 17e12ce commit 10438b6

File tree

1 file changed

+2
-51
lines changed

1 file changed

+2
-51
lines changed

.github/workflows/build-nodejs.yml

Lines changed: 2 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ on:
1313
description: 'Release tag (e.g., v0.1.0) - triggers release + publish'
1414
required: false
1515
type: string
16-
skip_tests:
17-
description: 'Skip test jobs'
18-
required: false
19-
type: boolean
20-
default: false
2116

2217
env:
2318
CARGO_TERM_COLOR: always
@@ -145,54 +140,10 @@ jobs:
145140
name: bindings-darwin-universal
146141
path: lni_js.darwin-universal.node
147142

148-
# Test the builds
149-
test:
150-
if: ${{ !inputs.skip_tests }}
151-
needs: build
152-
strategy:
153-
fail-fast: false
154-
matrix:
155-
include:
156-
- os: ubuntu-latest
157-
artifact: bindings-linux-x64-gnu
158-
- os: macos-latest # Apple Silicon runner
159-
artifact: bindings-darwin-arm64
160-
- os: windows-latest
161-
artifact: bindings-win32-x64-msvc
162-
163-
runs-on: ${{ matrix.os }}
164-
name: Test - ${{ matrix.os }}
165-
166-
steps:
167-
# actions/checkout@v4
168-
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5
169-
170-
- name: Setup Node.js
171-
# actions/setup-node@v4
172-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
173-
with:
174-
node-version: '20'
175-
176-
- name: Download artifact
177-
# actions/download-artifact@v4
178-
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093
179-
with:
180-
name: ${{ matrix.artifact }}
181-
path: bindings/lni_nodejs
182-
183-
- name: Install dependencies
184-
working-directory: bindings/lni_nodejs
185-
run: yarn install --mode=skip-build
186-
187-
- name: Test import
188-
working-directory: bindings/lni_nodejs
189-
run: |
190-
node -e "const lni = require('./'); console.log('✅ LNI loaded:', Object.keys(lni).slice(0,5).join(', '))"
191-
192143
# Create release on tag
193144
release:
194-
if: ${{ always() && !cancelled() && !failure() && (startsWith(github.ref, 'refs/tags/v') || inputs.release_tag != '') }}
195-
needs: [build, universal-macos, test]
145+
if: ${{ startsWith(github.ref, 'refs/tags/v') || inputs.release_tag != '' }}
146+
needs: [build, universal-macos]
196147
runs-on: ubuntu-latest
197148
name: Create Release
198149
permissions:

0 commit comments

Comments
 (0)