From b6bbc231f5513fa4d5a5dd3a1e11f7d85a17a127 Mon Sep 17 00:00:00 2001 From: Olly Marsay Date: Wed, 17 Sep 2025 16:11:05 +0100 Subject: [PATCH 1/2] to update work history the raw needs to be passed back to the update method, adding this as an option --- lib/bob/api/employee/work_history.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/bob/api/employee/work_history.rb b/lib/bob/api/employee/work_history.rb index 78c6727..6d13fe2 100644 --- a/lib/bob/api/employee/work_history.rb +++ b/lib/bob/api/employee/work_history.rb @@ -3,9 +3,12 @@ module Bob module Employee class WorkHistory < API - def self.all(employee_id) + def self.all(employee_id, include_raw: false) response = get("people/#{employee_id}/work") - WorkHistoryParser.new(response).work_histories + parsed = WorkHistoryParser.new(response).work_histories + return { data: parsed, raw: response.values.first } if include_raw + + parsed end def self.create(employee_id, params) @@ -13,10 +16,7 @@ def self.create(employee_id, params) end def self.update(employee_id, work_history_id, params) - put( - "people/#{employee_id}/work/#{work_history_id}", - params - ) + put("people/#{employee_id}/work/#{work_history_id}", params) end def self.remove(employee_id, work_history_id) From e9ab6825cd456e3e71af13dd9e87345eaeda006a Mon Sep 17 00:00:00 2001 From: Olly Marsay Date: Mon, 6 Oct 2025 17:27:57 +0100 Subject: [PATCH 2/2] move return up --- lib/bob/api/employee/work_history.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/bob/api/employee/work_history.rb b/lib/bob/api/employee/work_history.rb index 6d13fe2..1924e17 100644 --- a/lib/bob/api/employee/work_history.rb +++ b/lib/bob/api/employee/work_history.rb @@ -5,10 +5,9 @@ module Employee class WorkHistory < API def self.all(employee_id, include_raw: false) response = get("people/#{employee_id}/work") - parsed = WorkHistoryParser.new(response).work_histories - return { data: parsed, raw: response.values.first } if include_raw + return { raw: response.values.first } if include_raw - parsed + WorkHistoryParser.new(response).work_histories end def self.create(employee_id, params)