From 54fcb0b5d21828b19c81c62f912c1c35ab7d27b4 Mon Sep 17 00:00:00 2001 From: Ihor Dutchak Date: Fri, 21 Feb 2025 19:18:50 +0200 Subject: [PATCH 1/2] Replace deprecated upload-artifact@v3 Update to v4 for upload-artifact/download-artifact. --- .github/workflows/builds.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index 33191e3e..c462deca 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -50,7 +50,7 @@ jobs: run: ctest --output-junit test_static.xml ${{ env.COMMON_CTEST_ARGS }} - name: Upload Test Results if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: Test Results Ubuntu path: | @@ -98,7 +98,7 @@ jobs: run: ctest --output-junit test_static.xml ${{ env.COMMON_CTEST_ARGS }} - name: Upload Test Results if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: Test Results macOS path: | @@ -204,7 +204,7 @@ jobs: run: ctest --output-junit test_ninja_static.xml ${{ env.COMMON_CTEST_ARGS }} - name: Upload Test Results if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: Test Results MSVC path: | @@ -304,7 +304,7 @@ jobs: steps: - name: Download Artifacts - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: path: artifacts - name: Publish Test Results From 021c9b924d436b20d0010c82702c75539665e659 Mon Sep 17 00:00:00 2001 From: Ihor Dutchak Date: Fri, 21 Feb 2025 19:27:17 +0200 Subject: [PATCH 2/2] Fix typo in CTest argument --- .github/workflows/builds.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml index c462deca..e4c9537d 100644 --- a/.github/workflows/builds.yml +++ b/.github/workflows/builds.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest env: # set_option known to fail on Github Actions - COMMON_CTEST_ARGS: ---no-compress-output --output-on-failure -E "^set_option$" + COMMON_CTEST_ARGS: --no-compress-output --output-on-failure -E "^set_option$" steps: - uses: actions/checkout@v3