fix: envs

Author: agmmtoo

.env.example

@@ -1,5 +1,5 @@
 API_URL=
-APP_URL=
+NEXT_PUBLIC_APP_URL=
 
 FIREBASE_API_KEY=
 FIREBASE_AUTH_DOMAIN=

.github/workflows/prod-deploy.yml

@@ -29,15 +29,15 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: ${{ secrets.AWS_REGION }}
 
-      - name: export secret key
-        run: |
-          echo "${{ vars.production_ENV }}" > .env
+      # - name: export secret key
+      #   run: |
+      #     echo "${{ vars.production_ENV }}" > .env
 
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
         with:
-          mask-password: 'true'
+          mask-password: "true"
 
       # This is a separate action that sets up buildx runner
       - name: Setup Docker Buildx
@@ -58,8 +58,11 @@ jobs:
           ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
           ECR_REPOSITORY: ${{ secrets.REPOSITORY }}
           IMAGE_TAG: ${{ vars.IMAGE_TAG }}
+          NEXT_PUBLIC_APP_URL: ${{ vars.NEXT_PUBLIC_APP_URL }}
         run: |
-          docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
+          docker build \
+            --build-arg NEXT_PUBLIC_APP_URL=$NEXT_PUBLIC_APP_URL \
+            -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG .
           docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
 
   deploy-frontend-service:

Dockerfile

@@ -19,6 +19,10 @@ FROM node:24-alpine AS builder
 WORKDIR /app
 COPY . .
 
+# Accept build arguments for NEXT_PUBLIC environment variables
+ARG NEXT_PUBLIC_APP_URL
+ENV NEXT_PUBLIC_APP_URL=$NEXT_PUBLIC_APP_URL
+
 RUN yarn
 
 RUN yarn build

app/layout.tsx

@@ -25,7 +25,7 @@ export const viewport: Viewport = {
 export const metadata: Metadata = {
   title: SITE_NAME,
   description: SITE_DESCRIPTION,
-  metadataBase: new URL(process.env.APP_URL!),
+  metadataBase: new URL(process.env.NEXT_PUBLIC_APP_URL!),
   keywords: [
     'library management',
     'book tracking',

app/robots.ts

@@ -14,6 +14,6 @@ export default function robots(): MetadataRoute.Robots {
         '/users/*',
       ],
     },
-    sitemap: `${process.env.APP_URL}/sitemap.xml`,
+    sitemap: `${process.env.NEXT_PUBLIC_APP_URL}/sitemap.xml`,
   }
 }

lib/actions/login.ts

@@ -50,9 +50,8 @@ export async function loginAction(
   cookieStore.set(sessionName, token, {
     maxAge,
     httpOnly: true,
-    domain: `.${process.env.APP_URL?.slice(process.env.APP_URL.indexOf('://') + 3)}`,
-    secure: process.env.NODE_ENV === 'production',
-    sameSite: 'lax',
+    secure: true,
+    sameSite: 'strict',
   })
 
   // set active library

lib/api/common.ts

@@ -1,3 +1,4 @@
-// utilized next.config.js rewrites
-// cookies are available in client requests
-export const BASE_URL = `${process.env.APP_URL}/api/v1`
+export const BASE_URL =
+  typeof window === 'undefined'
+    ? `${process.env.API_URL}/api/v1`
+    : `${process.env.NEXT_PUBLIC_APP_URL}/api/v1`

package.json

@@ -4,6 +4,7 @@
   "private": true,
   "scripts": {
     "dev": "next dev --turbopack",
+    "devs": "next dev --turbopack --experimental-https",
     "build": "next build --turbopack",
     "start": "next start",
     "lint": "eslint .",