Segfault When quitting the demo on Mac

[oubiwann]

2016-04-29 11:19:38.183 [<0.49.0>] [debug] Start: ok
2016-04-29 11:19:38.183 [<0.49.0>] [debug] Stop on exit: ok
libpng warning: iCCP: known incorrect sRGB profile
                                                  make: *** [repl] Segmentation fault: 11

More insight may be gained here by watching for the window events that occur when quitting ...

[rvirding]

Yes, I get that happening as well. Maybe we just need to shut down esdl properly before terminating erlang. I will have to ask Loïc about it.

[oubiwann]

@essen Have you run into segfault issues when quitting esdl2 apps (or just the demo) when running on a Mac?

[essen]

Some history is here: ninenines/esdl2#2

At the end there's two PRs fixing issues. I do not have an OSX to try them, so feedback is welcome.

[oubiwann]

Fantastic, @essen -- thanks!

[rvirding]

I pulled the latest version, compiled it and tried it with my space ships and got this error when I started:

beam.smp(16662,0xb04b6000) malloc: *** error for object 0xb04b5c28: pointer being freed was not allocated
                         *** set a breakpoint in malloc_error_break to debug
                                                                            Abort trap: 6

A very simple fix which removes this problem is:

diff --git a/Makefile b/Makefile
index 12cc181..19e632c 100644
--- a/Makefile
+++ b/Makefile
@@ -22,8 +22,8 @@ SDL2_LIBS = $(filter-out $(SDL2_LIBS_FILTER_OUT),$(shell sdl2-

 CFLAGS += $(shell sdl2-config --cflags)
 # @todo -undefined dynamic_lookup on OSX?
-LDLIBS += $(SDL2_LIBS) -lSDL2_image
-
+#LDLIBS += $(SDL2_LIBS) -lSDL2_image
+LDFLAGS += -undefined dynamic_lookup $(SDL2_LIBS) -lSDL2_image
 include erlang.mk

 ifeq ($(PLATFORM),msys2)

I don't know why it works, it wasn't my idea. I am running Mac OSX 10.9.5.

[essen]

I think Erlang.mk does that automatically now but esdl2 might not have been updated yet.