Several improvements

[EmmanuelLab]

Hello,

I have just discovered OOSheet which seems very interesting to me.
Trying to use it I encountered several problems with my W7 and LibreOffice 3.5 configuration.

I made also several suggestions of improvements such as :

Add fileName and singleton parameters in OODoc.init

- saying if OODoc acts as singleton (default True)

- allowing to load filename directly

separate OOSheet.selector() call in OOSheet.init()

separate OOSheet._setRowSliced() call in OOSheet.init()

change OODoc.get_model() to add fileName parameter

in OODoc._file_url() change os.environ['PWD'] by os.getcwd()

Move OOSheet.Quit() to OODoc.quit() and reinit OODoc fields in quit()

correct bug in OOPacker.script_name() for W7

Change fetching InstallPath winreg key for LibreOffice 3.4 on W7

Change OODoc.get_context() to automatically start LibreOffice

optimize OODoc.get_context() to react as soon as soffice has started

Add OODoc.launch_soffice() and OODoc.socket_connect()

Correct ident pb in OODoc.alert()

Proposed changes are all arround the 4 sources (init.py, columns.py, tests\run_tests.py and tests\tests.py)
Being new to git I do not know how to send these change propositions all together.

Best regards
Emmanuel.

[lfagundes]

Hi Emmanuel,

Thanks for the suggestions. Sorry for taking so long to reply, I didn't notice the comment here.

Can you send these files by e-mail to me? lhfagundes at gmail dot com. I'll be glad to check all your suggestions and merge with current code.

For me, OOSheet is a very promising project. For it to grow we need more people using and asking for features, like you.

It's also nice to have more windows testers around, since I don't use it myself.

cheers
Luis

[lfagundes]

Hi Emmanuel,

You can see that I've filtered some code you sent and made some commits in your name. I haven't yet check everything, but I'm accepting everything that are small changes that make sense, like renaming methods that should be private, moving methods to proper class. If that's not there yet, I`ll put soon.

I'm rejecting stuff that is just a coding style and is not pythonic, like having a method just to set a property. I also rejected that "self.selector = selector", as this will break tests. As it is now, several functionalities rely on selector being dinamic, and we'll need more changes to cache this (and no one has reported this as a performance issue).

And for the most important thing, the filename parameter, opening a (possibly headless) Libreoffice instance and having the singleton parameter. The filename looks a nice feature, and I see that the singleton parameter is a consequence. For the filename to work there is still a missing code, as we need to make it generic for windows and linux. I don't see a case where we don't want the connection to be a singleton, as otherwise the performance is awful, in a way that using OOSheet is impossible. So, I think we should have other ways to deal with the situation where the Libreoffice instance is closed, like reconnecting automatically, instead of removing the connection cache.

Once more, thanks.

cheers
Luis