Skip to content

is it a bug in HyperbolicMLR? #15

@chenkq7

Description

@chenkq7

Thanks a lot for sharing your repo. I am new to hyperbolic neural networks, and I learned a lot from your repo.
While i am reading the code of examples/mnist.py, i am curious about why ToPoincare is only applied for x which is calculated by a neural network, whereas, ToPoincare is not applied for p_val in HyperbolicMLR.

p_vals_poincare = pmath.expmap0(self.p_vals, c=c)

consider that they are both need a expmap0 to map them from $R^2$ to $D^2$, won't p_val get a wrong gradient?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions