[Suggestion] Applying zzz's flip bitangent sign to hi3 part 2

[AzulFlamaWallon]

(I used gemini translate)

Hello, First of all, thank you for your incredible work on these tools.

I am writing to suggest a feature update regarding the character modding for hi3 part 2. I noticed that some hi3 part 2 characters currently suffer from an issue where the light direction is wrong.

I recalled that zzz characters previously had a very similar issue, which was resolved using xxmi tools. Based on this, I tested applying the same logic/functionality used for zzz to the hi3 part 2 character files as shown in the code below:

if cls.game == GameEnum.ZenlessZoneZero or cls.game == GameEnum.HonkaiImpactPart2:
            bitan_abstract: AbstractSemantic = AbstractSemantic(Semantic.BitangentSign)
            if cls.buffers_format["Position"].get_element(bitan_abstract) is not None:
                cls.format_converters[bitan_abstract] = [
                    lambda data: cls.converter_flip_bitangent_sign(data)
                ]

After applying this change, the light direction issue was successfully resolved. Would it be possible to officially incorporate this fix into the tool? I believe this would be a great help to the hi3 modding.

Thank you for your time and consideration.

this is original:




it is modded but not edit script:




it is modded but edit script:

[SinsOfSeven]

Thanks for the feedback. This appears correct in this case. We'll apply this change, and maybe make it easier to control in the future.