Skip to content

Remove leftover ShelfDTO import and unused variable #309

@leodvincci

Description

@leodvincci

Remove leftover ShelfDTO import and unused variable

Type: Cleanup / Boundary
Priority: P2

Summary

BookDomainRepositoryImpl still imports ShelfDTO and declares ShelfDTO shelfDTO = null;.

Impact

Cross-context coupling remains; dead code.

Evidence

BookDomainRepositoryImpl.java line 12 and line 39.

import com.penrose.bibby.library.stacks.shelf.api.dtos.ShelfDTO;
// ...
ShelfDTO shelfDTO = null;

Proposed Fix

Remove import and variable.

Acceptance Criteria

  • rg "ShelfDTO" src/main/java/com/penrose/bibby/library/cataloging/book/infrastructure/repository/BookDomainRepositoryImpl.java returns no results.

Expected

No Shelf module types are referenced in BookDomainRepositoryImpl.

Actual

ShelfDTO is still imported and an unused variable remains.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions