Skip to content

Conversation

@MisRob
Copy link
Member

@MisRob MisRob commented Nov 10, 2025

Summary

Finalizes maintenance tasks, bugfixes, and nice-to-have's I've gathered in automations tracker throughout this year.

Maintenance

  • Makes decision logic about bot replies and Slack notifications be independent
    • Allowed more nuanced configuration and is easier to read and update
  • Re-organizes logic that detects contributors and close contributors
    • Allowed re-use in more actions and some bugfixes, and easy addition of new community-related workflows
  • Updates PR tracker workflow to follow conventions

Bugfixes

  • Fixes broken Slack message formatting when < or > used in issue title
  • Limits workflow managing GitHub comments to run only on open issues
  • Fixes PR tracker not being updated when PR from close contributor, when title updated, or review requested

Improvements

  • Even more strict filtering of notifications (full overview)
  • Appends info on author activity to Slack notification to make decisions on assignment requests simpler
  • Prevents bot chiming in when comment is from the same person who created the issue (full overview)

New

  • Reply for assignment request on an already assigned help-wanted issues (see full overview)
  • Holiday message on new PRs or issue comments by community
  • Reply on a new contributor pull request

Reviewer guidance

Commits can serve for more detailed overview of changes. Since I made lots of changes that are committed in layers as I was iterating and testing, it would make most sense to review the final version of each workflow as a whole though.

Except PR tracker workflow, I already tried all changes in my test organization. Would appreciate focus on

  • Security
  • Major issues
  • Phrasing of the new pull request reply

(there are many areas to further improve as for maintenance, error handling, ... next year :)

After the code review, I will do few final tests in our environment, and prepare related PRs in other repos.

so we can decide about assignment requests more easily.
when assignment request posted on an issue
that is  assigned to someone else, and send
bot reply in such a case.
Fixes broken Slack message formatting
when < or > used in issue title.
in the workflow that updates community
PRs spreadsheet.

This also fixes problems with the spreadsheet
not being updated when a PR was authored
by a close contributor.
we settled on in majority of workflows
(call-... file, github-script, same dependencies..)
when PR title changed, or when review requested.
@MisRob
Copy link
Member Author

MisRob commented Nov 10, 2025

@rtibbles I think it may be better to run linters and formatters after you've reviewed - so for now I've just pushed installation of the tooling.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumping out at me as an immediate concern - testing will give us the most assurance of the logic!

@MisRob MisRob changed the title Final '25 community-related automations package [DO NOT MERGE YET] Final '25 community-related automations package Dec 3, 2025
in favor of manual enable/disable (to prevent
from forgetting to enable/disable the workflow
and having it run many times unnecessarily)
@MisRob MisRob changed the title [DO NOT MERGE YET] Final '25 community-related automations package Final '25 community-related automations package Dec 4, 2025
MisRob added a commit to MisRob/kolibri that referenced this pull request Dec 4, 2025
MisRob pushed a commit to MisRob/studio that referenced this pull request Dec 4, 2025
MisRob pushed a commit to MisRob/kolibri-design-system that referenced this pull request Dec 4, 2025
MisRob pushed a commit to learningequality/le-utils that referenced this pull request Dec 4, 2025
MisRob pushed a commit to learningequality/ricecooker that referenced this pull request Dec 4, 2025
@MisRob MisRob requested a review from rtibbles December 4, 2025 18:36
@MisRob MisRob merged commit cb01975 into learningequality:main Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants