Skip to content

Confusing labels for update dialog #677

@user202729

Description

@user202729

When Elan is outdated, I see the following warning message when open vscode

Lean's version manager Elan is outdated: the installed version is 3.1.1, but a version of 4.0.0 is recommended.

Do you wish to update Elan?

[Proceed]                     [Update Elan]

private updateElanPrompt(mode: UpdateElanMode): { message: string; item: 'Update Elan' } {
switch (mode.kind) {
case 'Manual':
return {
message:
"This command will update Lean's version manager Elan to its most recent version.\n\n" +
'Do you wish to proceed?',
item: 'Update Elan',
}
case 'Outdated':
return {
message:
`Lean's version manager Elan is outdated: the installed version is ${mode.versions.currentVersion.toString()}, but a version of ${mode.versions.recommendedVersion.toString()} is recommended.\n\n` +
'Do you wish to update Elan?',
item: 'Update Elan',
}
}
}

The problem is that the button labels are confusing: [Proceed] should have been named, say, [Proceed with current version] or [Do not] etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions