IPv6 Source IP and Probe IP's Not Populating

[kellyjonbrazil]

Any idea why the destination IP address from the header and the source IP addresses from the probes are not populating?

Input:

traceroute6 to turner-tls.map.fastly.net (2a04:4e42:200::323) from 2600:1700:bab0:d40:985:f00a:98bd:f142, 5 hops max, 12 byte packets
 1  * * *
 2  2001:506:6000:11b:71:156:212:143  27.635 ms  20.383 ms  23.438 ms
 3  * * *
 4  2001:1890:ff:ff08:12:242:117:16  20.118 ms  20.327 ms  21.213 ms
 5  * * *

output (i'm converting to a dict/JSON object:

{"destination_ip": null, "destination_name": "turner-tls.map.fastly.net", "hops": [{"hop": "1", "probes": [{"annotation": null, "asn": null, "ip": null, "name": null, "rtt": null}]}, {"hop": "2", "probes": [{"annotation": null, "asn": null, "ip": null, "name": null, "rtt": "27.635"}, {"annotation": null, "asn": null, "ip": null, "name": null, "rtt": "20.383"}, {"annotation": null, "asn": null, "ip": null, "name": null, "rtt": "23.438"}]}, {"hop": "3", "probes": [{"annotation": null, "asn": null, "ip": null, "name": null, "rtt": null}]}, {"hop": "4", "probes": [{"annotation": null, "asn": null, "ip": null, "name": null, "rtt": "20.118"}, {"annotation": null, "asn": null, "ip": null, "name": null, "rtt": "20.327"}, {"annotation": null, "asn": null, "ip": null, "name": null, "rtt": "21.213"}]}, {"hop": "5", "probes": [{"annotation": null, "asn": null, "ip": null, "name": null, "rtt": null}]}]}

[kellyjonbrazil]

Was able to fix this. Looks like the IPv6 functionality was only tested on linux and not osx/bsd. Made a couple regular expression changes:

-RE_HEADER = re.compile(r'(\S+)\s+\((?:(\d+\.\d+\.\d+\.\d+)|([0-9a-fA-F:]+))\)')
+RE_HEADER = re.compile(r'(\S+)\s+\((?:(\d+\.\d+\.\d+\.\d+|[0-9a-fA-F:]+))\)')     # IPv6 was going into group3 instead of group2, so fixed that
 
-RE_PROBE_NAME_IP = re.compile(r'(\S+)\s+\((?:(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})|([0-9a-fA-F:]+))\)+')
+RE_PROBE_NAME_IP = re.compile(r'(\S+)\s+\((?:(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}|[0-9a-fA-F:]+))\)+')    # did the same with the groups here
+RE_PROBE_BSD_IPV6 = re.compile(r'\b(?:[A-Fa-f0-9]{1,4}:){7}[A-Fa-f0-9]{1,4}\b')   # created a new RE search for bsd-style ipv6 probes

Then updated a bit of the logic:

         probe_name_ip_match = RE_PROBE_NAME_IP.search(hop_string)
+        probe_bsd_ipv6_match = RE_PROBE_BSD_IPV6.search(hop_string)   # added search variable for bsd-style ipv6 probes
         if probe_name_ip_match:
             probe_name = probe_name_ip_match.group(1)
-            probe_ip = probe_name_ip_match.group(2) or probe_name_ip_match.group(3)        # removed group3 logic
+            probe_ip = probe_name_ip_match.group(2)               # since the updated RE puts ipv6 in group2 now
+        elif probe_bsd_ipv6_match:                               # add bsd-style condition
+            probe_name = None
+            probe_ip = probe_bsd_ipv6_match.group(0)      # here is the match for bsd-style ipv6
         else:
             probe_name = None
             probe_ip = None