Test unchecked lines.

These are mostly error conditions, which are now explicitly checked.

Author: rwb27

tests/test_base_descriptor.py

@@ -39,6 +39,18 @@ class Example:
     a body giving a longer description of what's going on.
     """
 
+    # The code that finds docstrings needs to ignore anything
+    # that's not a "simple name". The code below should not
+    # cause an error, but will cause a ``continue`` statement
+    # to skip actions, testing another code path when the
+    # class is analysed.
+    dict_attribute = {}
+    dict_attribute["foo"] = "bar"
+    """Here is a spurious docstring that should be ignored."""
+
+    base_descriptor = BaseDescriptor()
+    """This descriptor should raise NotImplementedError."""
+
 
 def test_docstrings_are_retrieved():
     """Check that the docstring can be picked up from the class definition."""
@@ -47,6 +59,30 @@ def test_docstrings_are_retrieved():
     assert docs["my_property"] == "Docs for my_property."
 
 
+def test_non_classes_raise_errors():
+    """Check we validate the input object.
+
+    If `get_class_attribute_docstrings` is called on something other than
+    a class, we should raise an error.
+    """
+
+    def dummy():
+        pass
+
+    with pytest.raises(TypeError):
+        get_class_attribute_docstrings(dummy)
+
+
+def test_uncheckable_class():
+    """Check we don't crash if we can't check a class.
+
+    If `inspect.getsource` fails, we should return an empty dict.
+    """
+    MyClass = type("MyClass", dict={"intattr": 10})
+    doc = get_class_attribute_docstrings(MyClass)
+    assert doc == {}
+
+
 def test_docstrings_are_cached():
     """Check that the docstrings aren't being regenerated every time."""
     docs1 = get_class_attribute_docstrings(Example)
@@ -92,3 +128,6 @@ def test_basedescriptor_get():
     e = Example()
     assert e.my_property == "An example value."
     assert isinstance(Example.my_property, MockProperty)
+    with pytest.raises(NotImplementedError):
+        # BaseDescriptor requires `instance_get` to be overridden.
+        e.base_descriptor