Removing unused settings dict features

Author: julianstirling

src/labthings_fastapi/server/__init__.py

@@ -13,7 +13,6 @@
     object_reference_to_object,
 )
 from ..actions import ActionManager
-from ..thing_settings import ThingSettings
 from ..thing import Thing
 from ..thing_description.model import ThingDescription
 from ..dependencies.thing_server import _thing_servers
@@ -82,9 +81,6 @@ def add_thing(self, thing: Thing, path: str):
         # TODO: check for illegal things in `path` - potential security issue.
         settings_folder = os.path.join(self.settings_folder, path.lstrip("/"))
         os.makedirs(settings_folder, exist_ok=True)
-        thing._labthings_thing_settings = ThingSettings(
-            os.path.join(settings_folder, "settings.json")
-        )
         thing.attach_to_server(self, path, os.path.join(settings_folder, "settings.json"))
 
     @asynccontextmanager
@@ -117,17 +113,6 @@ async def lifespan(self, app: FastAPI):
             for name, thing in self.things.items():
                 # Remove the blocking portal - the event loop is about to stop.
                 thing._labthings_blocking_portal = None
-                try:
-                    if thing._labthings_thing_settings:
-                        thing._labthings_thing_settings.write_to_file()
-                except PermissionError:
-                    logging.warning(
-                        f"Could not write {name} settings to disk: permission error."
-                    )
-                except FileNotFoundError:
-                    logging.warning(
-                        f"Could not write {name} settings, folder not found"
-                    )
 
         self.blocking_portal = None
 

src/labthings_fastapi/thing.py

@@ -25,7 +25,7 @@
 from .thing_description import validation
 from .utilities.introspection import get_summary, get_docstring
 from .websockets import websocket_endpoint, WebSocket
-from .thing_settings import ThingSettings
+
 
 if TYPE_CHECKING:
     from .server import ThingServer
@@ -130,30 +130,16 @@ def settings(self):
     _setting_storage_path: Optional[str] = None
 
     @property
-    def setting_storage_path(self) -> ThingSettings:
+    def setting_storage_path(self) -> str:
         """The storage path for settings. This is set at runtime."""
         return self._setting_storage_path
 
     def save_settings(self):
+        """This is automattically called when a setting is updated with a setter"""
         if self.settings is not None:
-            setting_dict = {name: self.__dict__[name] for name in self.settings}
+            setting_dict = {name: getattr(self, name) for name in self.settings}
             logging.warning(f'This should save {setting_dict} to {self._setting_storage_path}')
 
-    _labthings_thing_settings: Optional[ThingSettings] = None
-
-    @property
-    def thing_settings(self) -> ThingSettings:
-        """A dictionary that can be used to persist settings between runs"""
-        if self._labthings_thing_settings is None:
-            raise RuntimeError(
-                "Settings may not be accessed before we are attached to the server."
-            )
-        return self._labthings_thing_settings
-
-    @thing_settings.setter
-    def thing_settings(self, newsettings: ThingSettings):
-        self.thing_settings.replace(newsettings)
-
     _labthings_thing_state: Optional[dict] = None
 
     @property