Build fails on testcase_reader.cpp.o

[horsaen]

[ 62%] Building CXX object tests/CMakeFiles/orbit-t.dir/testcase_reader.cpp.o
/home/horsaen/git/libpredict/tests/testcase_reader.cpp: In function ‘std::string& ltrim(std::string&)’:
/home/horsaen/git/libpredict/tests/testcase_reader.cpp:35:93: error: ‘std::pointer_to_unary_function<_Arg, _Result> std::ptr_fun(_Result (*)(_Arg)) [with _Arg = int; _Result = int]’ is deprecated: use 'std::function' instead [-Werror=deprecated-declarations]
   35 |         s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun<int, int>(std::isspace))));
      |                                                                       ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
In file included from /usr/include/c++/13.1.1/string:49,
                 from /home/horsaen/git/libpredict/tests/testcase_reader.h:4,
                 from /home/horsaen/git/libpredict/tests/testcase_reader.cpp:1:
/usr/include/c++/13.1.1/bits/stl_function.h:1126:5: note: declared here
 1126 |     ptr_fun(_Result (*__x)(_Arg))
      |     ^~~~~~~
/home/horsaen/git/libpredict/tests/testcase_reader.cpp:35:70: error: ‘constexpr std::unary_negate<_Predicate> std::not1(const _Predicate&) [with _Predicate = pointer_to_unary_function<int, int>]’ is deprecated: use 'std::not_fn' instead [-Werror=deprecated-declarations]
   35 |         s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun<int, int>(std::isspace))));
      |                                                             ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/13.1.1/bits/stl_function.h:1046:5: note: declared here
 1046 |     not1(const _Predicate& __pred)
      |     ^~~~
/home/horsaen/git/libpredict/tests/testcase_reader.cpp: In function ‘std::string& rtrim(std::string&)’:
/home/horsaen/git/libpredict/tests/testcase_reader.cpp:41:84: error: ‘std::pointer_to_unary_function<_Arg, _Result> std::ptr_fun(_Result (*)(_Arg)) [with _Arg = int; _Result = int]’ is deprecated: use 'std::function' instead [-Werror=deprecated-declarations]
   41 |         s.erase(std::find_if(s.rbegin(), s.rend(), std::not1(std::ptr_fun<int, int>(std::isspace))).base(), s.end());
      |                                                              ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
/usr/include/c++/13.1.1/bits/stl_function.h:1126:5: note: declared here
 1126 |     ptr_fun(_Result (*__x)(_Arg))
      |     ^~~~~~~
/home/horsaen/git/libpredict/tests/testcase_reader.cpp:41:61: error: ‘constexpr std::unary_negate<_Predicate> std::not1(const _Predicate&) [with _Predicate = pointer_to_unary_function<int, int>]’ is deprecated: use 'std::not_fn' instead [-Werror=deprecated-declarations]
   41 |         s.erase(std::find_if(s.rbegin(), s.rend(), std::not1(std::ptr_fun<int, int>(std::isspace))).base(), s.end());
      |                                                    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/13.1.1/bits/stl_function.h:1046:5: note: declared here
 1046 |     not1(const _Predicate& __pred)
      |     ^~~~
cc1plus: all warnings being treated as errors
make[2]: *** [tests/CMakeFiles/orbit-t.dir/build.make:90: tests/CMakeFiles/orbit-t.dir/testcase_reader.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:314: tests/CMakeFiles/orbit-t.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

this occurs on arch linux, linux mint compiles fine.

any ideas ?

[ploeffler]

I confirm that on Armbian (lates version)
seems to be a --Werror=deprecated-declarations thing

[ 60%] Building CXX object tests/CMakeFiles/orbit-t.dir/testcase_reader.cpp.o /home/pi/libpredict/tests/testcase_reader.cpp: In function ‘std::string& ltrim(std::string&)’: /home/pi/libpredict/tests/testcase_reader.cpp:35:93: error: ‘std::pointer_to_unary_function<_Arg, _Result> std::ptr_fun(_Result (*)(_Arg)) [with _Arg = int; _Result = int]’ is deprecated: use 'std::function' instead [-Werror=deprecated-declarations] 35 | s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun<int, int>(std::isspace)))); | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ In file included from /usr/include/c++/12/string:48, from /home/pi/libpredict/tests/testcase_reader.h:4, from /home/pi/libpredict/tests/testcase_reader.cpp:1: /usr/include/c++/12/bits/stl_function.h:1126:5: note: declared here 1126 | ptr_fun(_Result (*__x)(_Arg)) | ^~~~~~~ /home/pi/libpredict/tests/testcase_reader.cpp:35:70: error: ‘constexpr std::unary_negate<_Predicate> std::not1(const _Predicate&) [with _Predicate = pointer_to_unary_function<int, int>]’ is deprecated: use 'std::not_fn' instead [-Werror=deprecated-declarations] 35 | s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun<int, int>(std::isspace)))); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/12/bits/stl_function.h:1046:5: note: declared here 1046 | not1(const _Predicate& __pred) | ^~~~ /home/pi/libpredict/tests/testcase_reader.cpp: In function ‘std::string& rtrim(std::string&)’: /home/pi/libpredict/tests/testcase_reader.cpp:41:84: error: ‘std::pointer_to_unary_function<_Arg, _Result> std::ptr_fun(_Result (*)(_Arg)) [with _Arg = int; _Result = int]’ is deprecated: use 'std::function' instead [-Werror=deprecated-declarations] 41 | s.erase(std::find_if(s.rbegin(), s.rend(), std::not1(std::ptr_fun<int, int>(std::isspace))).base(), s.end()); | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ /usr/include/c++/12/bits/stl_function.h:1126:5: note: declared here 1126 | ptr_fun(_Result (*__x)(_Arg)) | ^~~~~~~ /home/pi/libpredict/tests/testcase_reader.cpp:41:61: error: ‘constexpr std::unary_negate<_Predicate> std::not1(const _Predicate&) [with _Predicate = pointer_to_unary_function<int, int>]’ is deprecated: use 'std::not_fn' instead [-Werror=deprecated-declarations] 41 | s.erase(std::find_if(s.rbegin(), s.rend(), std::not1(std::ptr_fun<int, int>(std::isspace))).base(), s.end()); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/12/bits/stl_function.h:1046:5: note: declared here 1046 | not1(const _Predicate& __pred) | ^~~~ In file included from /usr/include/c++/12/vector:70, from /home/pi/libpredict/tests/testcase_reader.h:5: /usr/include/c++/12/bits/vector.tcc: In member function ‘void std::vector<_Tp, _Alloc>::_M_realloc_insert(iterator, _Args&& ...) [with _Args = {const double&}; _Tp = double; _Alloc = std::allocator<double>]’: /usr/include/c++/12/bits/vector.tcc:439:7: note: parameter passing for argument of type ‘std::vector<double>::iterator’ changed in GCC 7.1 439 | vector<_Tp, _Alloc>:: | ^~~~~~~~~~~~~~~~~~~ In file included from /usr/include/c++/12/vector:64: In member function ‘void std::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = double; _Alloc = std::allocator<double>]’, inlined from ‘void TestCaseReader::loadFromFile(const char*)’ at /home/pi/libpredict/tests/testcase_reader.cpp:185:17: /usr/include/c++/12/bits/stl_vector.h:1287:28: note: parameter passing for argument of type ‘__gnu_cxx::__normal_iterator<double*, std::vector<double> >’ changed in GCC 7.1 1287 | _M_realloc_insert(end(), __x); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ cc1plus: all warnings being treated as errors make[2]: *** [tests/CMakeFiles/orbit-t.dir/build.make:90: tests/CMakeFiles/orbit-t.dir/testcase_reader.cpp.o] Fehler 1 make[1]: *** [CMakeFiles/Makefile2:287: tests/CMakeFiles/orbit-t.dir/all] Fehler 2 make: *** [Makefile:146: all] Fehler 2

[1-Bart-1]

This is still a problem, I get deprecated errors when trying to build libpredict. Either the -Werror in these two lines should be removed, or the deprecated code has to be updated.

libpredict/CMakeLists.txt

Lines 30 to 31 in 47569d4

	set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Werror")
	set(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -Wall -Werror")