Skip to content

Commit 0752409

Browse files
committed
Fixup
1 parent 72246d8 commit 0752409

File tree

6 files changed

+30
-5
lines changed

6 files changed

+30
-5
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@
2424
"devDependencies": {
2525
"@tsconfig/node18": "^18.2.4",
2626
"@types/node": "18.19.76",
27+
"@types/semver": "^7.7.0",
2728
"@typescript-eslint/eslint-plugin": "^8.10.0",
2829
"@typescript-eslint/parser": "^8.10.0",
2930
"cross-env": "^7.0.3",
3031
"eslint": "^8.56.0",
3132
"eslint-plugin-tsdoc": "^0.2.17",
3233
"nx": "20.1.3",
3334
"prettier": "^2.8.8",
34-
"semver": "^7.6.3",
35+
"semver": "^7.7.2",
3536
"typescript": "^5.6.3"
3637
}
3738
}

packages/db-client/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
"@types/node": "^22.10.2",
5353
"debug": "^4.4.0",
5454
"google-protobuf": "^3.21.4",
55+
"semver": "^7.7.2",
5556
"uuid": "11.0.3"
5657
},
5758
"devDependencies": {

packages/db-client/src/persistentSubscription/utils/settingsToGRPC.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import semver from "semver";
88
import {
99
DISPATCH_TO_SINGLE,
1010
PINNED,
11+
PINNED_BY_CORRELATION,
1112
ROUND_ROBIN,
1213
UNBOUNDED,
1314
} from "../../constants";
@@ -16,6 +17,7 @@ import type {
1617
PersistentSubscriptionToStreamSettings,
1718
PersistentSubscriptionToAllSettings,
1819
} from "./persistentSubscriptionSettings";
20+
import { UnsupportedError } from "../../utils";
1921

2022
type GRPCSettings = typeof CreateReq.Settings | typeof UpdateReq.Settings;
2123

@@ -75,6 +77,9 @@ export const settingsToGRPC = <T extends GRPCSettings>(
7577
);
7678
break;
7779
}
80+
case PINNED_BY_CORRELATION: {
81+
throw new UnsupportedError(PINNED_BY_CORRELATION, "25.10.1");
82+
}
7883
default: {
7984
console.warn(
8085
`Unknown consumerStrategyName ${settings.consumerStrategyName}.`

packages/test/src/persistentSubscription/createPersistentSubscriptionToAll.test.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
START,
1616
UnsupportedError,
1717
PINNED_BY_CORRELATION,
18-
StreamNotFoundError,
1918
} from "@kurrent/kurrentdb-client";
2019

2120
describe("createPersistentSubscriptionToAll", () => {
@@ -100,9 +99,13 @@ describe("createPersistentSubscriptionToAll", () => {
10099
)
101100
).resolves.toBeUndefined();
102101

103-
const persistentSubscriptions =
102+
let persistentSubscriptions =
104103
await client.listAllPersistentSubscriptions();
105104

105+
persistentSubscriptions = persistentSubscriptions.filter(
106+
(ps) => ps.groupName === GROUP_NAME
107+
);
108+
106109
expect(persistentSubscriptions).toHaveLength(1);
107110
expect(persistentSubscriptions[0].groupName).toBe(GROUP_NAME);
108111
expect(persistentSubscriptions[0].settings.consumerStrategyName).toBe(

packages/test/src/persistentSubscription/createPersistentSubscriptionToStream.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,13 @@ describe("createPersistentSubscriptionToStream", () => {
7676
)
7777
).resolves.toBeUndefined();
7878

79-
const persistentSubscriptions =
79+
let persistentSubscriptions =
8080
await client.listAllPersistentSubscriptions();
8181

82+
persistentSubscriptions = persistentSubscriptions.filter(
83+
(ps) => ps.groupName === GROUP_NAME && ps.eventSource === STREAM_NAME
84+
);
85+
8286
expect(persistentSubscriptions).toHaveLength(1);
8387
expect(persistentSubscriptions[0].eventSource).toBe(STREAM_NAME);
8488
expect(persistentSubscriptions[0].settings.consumerStrategyName).toBe(

yarn.lock

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,7 @@ __metadata:
11371137
grpc-tools: "npm:^1.12.4"
11381138
grpc_tools_node_protoc_ts: "npm:^5.3.3"
11391139
nx: "npm:20.1.3"
1140+
semver: "npm:^7.7.2"
11401141
shx: "npm:^0.3.4"
11411142
uuid: "npm:11.0.3"
11421143
languageName: unknown
@@ -7177,14 +7178,15 @@ __metadata:
71777178
dependencies:
71787179
"@tsconfig/node18": "npm:^18.2.4"
71797180
"@types/node": "npm:18.19.76"
7181+
"@types/semver": "npm:^7.7.0"
71807182
"@typescript-eslint/eslint-plugin": "npm:^8.10.0"
71817183
"@typescript-eslint/parser": "npm:^8.10.0"
71827184
cross-env: "npm:^7.0.3"
71837185
eslint: "npm:^8.56.0"
71847186
eslint-plugin-tsdoc: "npm:^0.2.17"
71857187
nx: "npm:20.1.3"
71867188
prettier: "npm:^2.8.8"
7187-
semver: "npm:^7.6.3"
7189+
semver: "npm:^7.7.2"
71887190
typescript: "npm:^5.6.3"
71897191
languageName: unknown
71907192
linkType: soft
@@ -9585,6 +9587,15 @@ __metadata:
95859587
languageName: node
95869588
linkType: hard
95879589

9590+
"semver@npm:^7.7.2":
9591+
version: 7.7.2
9592+
resolution: "semver@npm:7.7.2"
9593+
bin:
9594+
semver: bin/semver.js
9595+
checksum: 10c0/aca305edfbf2383c22571cb7714f48cadc7ac95371b4b52362fb8eeffdfbc0de0669368b82b2b15978f8848f01d7114da65697e56cd8c37b0dab8c58e543f9ea
9596+
languageName: node
9597+
linkType: hard
9598+
95889599
"set-blocking@npm:^2.0.0":
95899600
version: 2.0.0
95909601
resolution: "set-blocking@npm:2.0.0"

0 commit comments

Comments
 (0)