From fd1a62fd19bfee901c625d5c1719790df908477b Mon Sep 17 00:00:00 2001
From: Daniel Bauer <daniel.bauer@kupferwerk.com>
Date: Thu, 15 Dec 2016 09:46:13 +0100
Subject: [PATCH 1/2] apply quality plugin

---
 app/build.gradle                     |   1 +
 app/config/checkstyle/checkstyle.xml | 162 --------------------
 app/config/checkstyle/checkstyle.xsl | 218 ---------------------------
 build.gradle                         |   8 +
 4 files changed, 9 insertions(+), 380 deletions(-)
 delete mode 100644 app/config/checkstyle/checkstyle.xml
 delete mode 100644 app/config/checkstyle/checkstyle.xsl

diff --git a/app/build.gradle b/app/build.gradle
index 224a654..0913ebc 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -1,6 +1,7 @@
 apply plugin: 'com.android.application'
 apply plugin: 'checkstyle'
 apply plugin: 'com.neenbedankt.android-apt'
+//apply plugin: 'com.intive.codequality'
 
 android {
 
diff --git a/app/config/checkstyle/checkstyle.xml b/app/config/checkstyle/checkstyle.xml
deleted file mode 100644
index 428bd4b..0000000
--- a/app/config/checkstyle/checkstyle.xml
+++ /dev/null
@@ -1,162 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC
-    "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
-    "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
-
-<!--
-    This configuration file was written by the eclipse-cs plugin configuration editor
---><!--
-    Checkstyle-Configuration: Android_Checkstyle
-    Description: none
--->
-<module name="Checker">
-    <property name="severity" value="warning" />
-    <module name="TreeWalker">
-        <property name="tabWidth" value="4" />
-        <module name="FileContentsHolder" />
-        <module name="MissingOverride" />
-        <module name="JavadocMethod">
-            <property name="severity" value="ignore" />
-            <property name="scope" value="protected" />
-            <property name="allowUndeclaredRTE" value="true" />
-            <property name="suppressLoadErrors" value="true" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="JavadocStyle">
-            <property name="severity" value="ignore" />
-            <property name="checkEmptyJavadoc" value="true" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="JavadocType">
-            <property name="severity" value="ignore" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="ConstantName" />
-        <module name="LocalFinalVariableName" />
-        <module name="LocalVariableName" />
-        <module name="MemberName">
-            <property name="applyToPackage" value="false" />
-            <property name="applyToPrivate" value="false" />
-        </module>
-        <module name="MethodName" />
-        <module name="MethodTypeParameterName" />
-        <module name="PackageName" />
-        <module name="ParameterName" />
-        <module name="StaticVariableName" />
-        <module name="TypeName" />
-        <module name="IllegalImport" />
-        <module name="RedundantImport" />
-        <module name="UnusedImports" />
-        <module name="AnonInnerLength" />
-        <module name="LineLength">
-            <metadata name="net.sf.eclipsecs.core.comment"
-                value="Give a few more characters to allow exlipse auto formatter some exceptions from 80 characters if it wants so..." />
-            <property name="severity" value="ignore" />
-            <property name="ignorePattern" value="^import.*$" />
-            <property name="max" value="100" />
-            <property name="tabWidth" value="4" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="MethodLength">
-            <property name="max" value="40" />
-        </module>
-        <module name="ParameterNumber">
-            <property name="max" value="9" />
-        </module>
-        <module name="GenericWhitespace" />
-        <module name="EmptyForInitializerPad" />
-        <module name="EmptyForIteratorPad" />
-        <module name="NoWhitespaceAfter">
-            <property name="tokens" value="BNOT,DEC,DOT,INC,LNOT,UNARY_MINUS,UNARY_PLUS" />
-        </module>
-        <module name="NoWhitespaceBefore" />
-        <module name="TypecastParenPad">
-            <property name="tokens" value="RPAREN,TYPECAST" />
-        </module>
-        <module name="WhitespaceAfter" />
-        <module name="WhitespaceAround" />
-        <module name="ModifierOrder" />
-        <module name="RedundantModifier">
-            <property name="severity" value="ignore" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="EmptyBlock">
-            <property name="option" value="text" />
-        </module>
-        <module name="LeftCurly" />
-        <module name="NeedBraces" />
-        <module name="RightCurly" />
-        <module name="AvoidInlineConditionals" />
-        <module name="DefaultComesLast" />
-        <module name="EmptyStatement" />
-        <module name="EqualsAvoidNull">
-            <message key="equals.avoid.null"
-                value="String literal expressions should be on the left side of an equals comparison. This may avoid a NullPointerException." />
-        </module>
-        <module name="EqualsHashCode" />
-        <module name="FallThrough" />
-        <module name="IllegalCatch" />
-        <module name="IllegalThrows" />
-        <module name="MagicNumber" />
-        <module name="MissingSwitchDefault" />
-        <module name="MultipleStringLiterals">
-            <property name="ignoreStringsRegexp"
-                value="^&quot;(\s*)&quot;$|^&quot;(\s*)'(\s*)&quot;$|^&quot;/&quot;$|^&quot;(\s*):(\s*)&quot;|^&quot;(\s*)\[(\s*)&quot;$|^&quot;(\s*)\](\s*)&quot;$" />
-            <property name="ignoreOccurrenceContext" value="LITERAL_THROW,ANNOTATION" />
-        </module>
-        <module name="MultipleVariableDeclarations" />
-        <module name="NestedIfDepth">
-            <property name="max" value="2" />
-        </module>
-        <module name="NestedTryDepth">
-            <property name="max" value="2" />
-        </module>
-        <module name="PackageDeclaration" />
-        <module name="SimplifyBooleanExpression" />
-        <module name="SimplifyBooleanReturn" />
-        <module name="StringLiteralEquality" />
-        <module name="SuperClone" />
-        <module name="SuperFinalize" />
-        <module name="VisibilityModifier">
-            <property name="severity" value="ignore" />
-            <property name="packageAllowed" value="true" />
-            <property name="protectedAllowed" value="true" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="BooleanExpressionComplexity" />
-        <module name="CyclomaticComplexity" />
-        <module name="NPathComplexity" />
-        <module name="ClassFanOutComplexity">
-            <property name="max" value="25" />
-        </module>
-        <module name="TrailingComment" />
-        <module name="UpperEll" />
-        <module name="JavadocVariable">
-            <property name="severity" value="ignore" />
-            <property name="scope" value="package" />
-            <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-        </module>
-        <module name="MissingDeprecated" />
-        <module name="PackageAnnotation" />
-        <module name="AnnotationUseStyle" />
-        <module name="MemberName">
-            <property name="applyToPrivate" value="false" />
-        </module>
-        <module name="MemberName">
-            <property name="applyToPrivate" value="false" />
-        </module>
-    </module>
-    <module name="JavadocPackage">
-        <property name="severity" value="ignore" />
-        <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit" />
-    </module>
-    <module name="FileLength">
-        <property name="max" value="800" />
-    </module>
-    <!--<module name="NewlineAtEndOfFile"/>-->
-    <module name="SuppressionCommentFilter" />
-    <module name="FileTabCharacter" />
-    <module name="RegexpSingleline">
-        <property name="format" value="printStackTrace" />
-        <property name="message" value="Handle exception correctly or use logging." />
-    </module>
-</module>
diff --git a/app/config/checkstyle/checkstyle.xsl b/app/config/checkstyle/checkstyle.xsl
deleted file mode 100644
index 232bc59..0000000
--- a/app/config/checkstyle/checkstyle.xsl
+++ /dev/null
@@ -1,218 +0,0 @@
-<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
-    <!--
-       Licensed to the Apache Software Foundation (ASF) under one or more
-       contributor license agreements.  See the NOTICE file distributed with
-       this work for additional information regarding copyright ownership.
-       The ASF licenses this file to You under the Apache License, Version 2.0
-       (the "License"); you may not use this file except in compliance with
-       the License.  You may obtain a copy of the License at
-
-           http://www.apache.org/licenses/LICENSE-2.0
-
-       Unless required by applicable law or agreed to in writing, software
-       distributed under the License is distributed on an "AS IS" BASIS,
-       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-       See the License for the specific language governing permissions and
-       limitations under the License.
-    -->
-
-    <xsl:output indent="yes" method="html" />
-    <xsl:decimal-format decimal-separator="." grouping-separator="," />
-
-    <xsl:key name="files" match="file" use="@name" />
-
-    <!-- Checkstyle XML Style Sheet by Stephane Bailliez <sbailliez@apache.org>         -->
-    <!-- Part of the Checkstyle distribution found at http://checkstyle.sourceforge.net -->
-    <!-- Usage (generates checkstyle_report.html):                                      -->
-    <!--    <checkstyle failonviolation="false" config="${check.config}">               -->
-    <!--      <fileset dir="${src.dir}" includes="**/*.java"/>                          -->
-    <!--      <formatter type="xml" toFile="${doc.dir}/checkstyle_report.xml"/>         -->
-    <!--    </checkstyle>                                                               -->
-    <!--    <style basedir="${doc.dir}" destdir="${doc.dir}"                            -->
-    <!--            includes="checkstyle_report.xml"                                    -->
-    <!--            style="${doc.dir}/checkstyle-noframes-sorted.xsl"/>                 -->
-
-    <xsl:template match="checkstyle">
-        <html>
-            <head>
-                <style type="text/css">
-                    .bannercell {
-                    border: 0px;
-                    padding: 0px;
-                    }
-                    body {
-                    margin-left: 10;
-                    margin-right: 10;
-                    font:normal 80% arial,helvetica,sanserif;
-                    background-color:#FFFFFF;
-                    color:#000000;
-                    }
-                    .a td {
-                    background: #efefef;
-                    }
-                    .b td {
-                    background: #fff;
-                    }
-                    th, td {
-                    text-align: left;
-                    vertical-align: top;
-                    }
-                    th {
-                    font-weight:bold;
-                    background: #ccc;
-                    color: black;
-                    }
-                    table, th, td {
-                    font-size:100%;
-                    border: none
-                    }
-                    table.log tr td, tr th {
-
-                    }
-                    h2 {
-                    font-weight:bold;
-                    font-size:140%;
-                    margin-bottom: 5;
-                    }
-                    h3 {
-                    font-size:100%;
-                    font-weight:bold;
-                    background: #525D76;
-                    color: white;
-                    text-decoration: none;
-                    padding: 5px;
-                    margin-right: 2px;
-                    margin-left: 2px;
-                    margin-bottom: 0;
-                    }
-                </style>
-            </head>
-            <body>
-                <a name="top"></a>
-                <!-- jakarta logo -->
-                <table border="0" cellpadding="0" cellspacing="0" width="100%">
-                    <tr>
-                        <td class="bannercell" rowspan="2">
-                            <!--a href="http://jakarta.apache.org/">
-                            <img src="http://jakarta.apache.org/images/jakarta-logo.gif" alt="http://jakarta.apache.org" align="left" border="0"/>
-                            </a-->
-                        </td>
-                        <td class="text-align:right">
-                            <h2>CheckStyle Audit</h2>
-                        </td>
-                    </tr>
-                    <tr>
-                        <td class="text-align:right">Designed for use with
-                            <a href='http://checkstyle.sourceforge.net/'>CheckStyle</a>
-                            and<a href='http://jakarta.apache.org'>Ant</a>.
-                        </td>
-                    </tr>
-                </table>
-                <hr size="1" />
-
-                <!-- Summary part -->
-                <xsl:apply-templates mode="summary" select="." />
-                <hr align="left" size="1" width="100%" />
-
-                <!-- Package List part -->
-                <xsl:apply-templates mode="filelist" select="." />
-                <hr align="left" size="1" width="100%" />
-
-                <!-- For each package create its part -->
-                <xsl:apply-templates
-                    select="file[@name and generate-id(.) = generate-id(key('files', @name))]" />
-
-                <hr align="left" size="1" width="100%" />
-
-
-            </body>
-        </html>
-    </xsl:template>
-
-
-    <xsl:template match="checkstyle" mode="filelist">
-        <h3>Files</h3>
-        <table border="0" cellpadding="5" cellspacing="2" class="log" width="100%">
-            <tr>
-                <th>Name</th>
-                <th>Errors</th>
-            </tr>
-            <xsl:for-each
-                select="file[@name and generate-id(.) = generate-id(key('files', @name))]">
-                <xsl:sort data-type="number" order="descending"
-                    select="count(key('files', @name)/error)" />
-                <xsl:variable name="errorCount" select="count(error)" />
-                <tr>
-                    <xsl:call-template name="alternated-row" />
-                    <td>
-                        <a href="#f-{@name}">
-                            <xsl:value-of select="@name" />
-                        </a>
-                    </td>
-                    <td>
-                        <xsl:value-of select="$errorCount" />
-                    </td>
-                </tr>
-            </xsl:for-each>
-        </table>
-    </xsl:template>
-
-
-    <xsl:template match="file">
-        <a name="f-{@name}"></a>
-        <h3>File
-            <xsl:value-of select="@name" />
-        </h3>
-
-        <table border="0" cellpadding="5" cellspacing="2" class="log" width="100%">
-            <tr>
-                <th>Error Description</th>
-                <th>Line</th>
-            </tr>
-            <xsl:for-each select="key('files', @name)/error">
-                <xsl:sort data-type="number" order="ascending" select="@line" />
-                <tr>
-                    <xsl:call-template name="alternated-row" />
-                    <td>
-                        <xsl:value-of select="@message" />
-                    </td>
-                    <td>
-                        <xsl:value-of select="@line" />
-                    </td>
-                </tr>
-            </xsl:for-each>
-        </table>
-        <a href="#top">Back to top</a>
-    </xsl:template>
-
-
-    <xsl:template match="checkstyle" mode="summary">
-        <h3>Summary</h3>
-        <xsl:variable name="fileCount"
-            select="count(file[@name and generate-id(.) = generate-id(key('files', @name))])" />
-        <xsl:variable name="errorCount" select="count(file/error)" />
-        <table border="0" cellpadding="5" cellspacing="2" class="log" width="100%">
-            <tr>
-                <th>Files</th>
-                <th>Errors</th>
-            </tr>
-            <tr>
-                <xsl:call-template name="alternated-row" />
-                <td>
-                    <xsl:value-of select="$fileCount" />
-                </td>
-                <td>
-                    <xsl:value-of select="$errorCount" />
-                </td>
-            </tr>
-        </table>
-    </xsl:template>
-
-    <xsl:template name="alternated-row">
-        <xsl:attribute name="class">
-            <xsl:if test="position() mod 2 = 1">a</xsl:if>
-            <xsl:if test="position() mod 2 = 0">b</xsl:if>
-        </xsl:attribute>
-    </xsl:template>
-</xsl:stylesheet>
-
diff --git a/build.gradle b/build.gradle
index a476bb0..7871618 100644
--- a/build.gradle
+++ b/build.gradle
@@ -3,6 +3,13 @@ apply plugin: 'com.github.ben-manes.versions'
 
 buildscript {
    repositories {
+      /*maven {
+         url "https://nexus.kupferwerk.net/content/repositories/snapshots/"
+         credentials {
+            username '<<place username here>>'
+            password '<<place username here>>'
+         }
+      }*/
       jcenter()
    }
    dependencies {
@@ -10,6 +17,7 @@ buildscript {
       classpath 'com.github.ben-manes:gradle-versions-plugin:0.11.3'
       // Assists in working with annotation processors for Android Studio.
       classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8'
+      //classpath 'com.intive.codequality:gradle-plugin:1.0.0-SNAPSHOT'
    }
 }
 

From 5ea19ce3e5acb32f7ec157ff65af04cbfe736fa8 Mon Sep 17 00:00:00 2001
From: Daniel Bauer <daniel.bauer@kupferwerk.com>
Date: Thu, 15 Dec 2016 10:16:48 +0100
Subject: [PATCH 2/2] removed checkstyle plugin

---
 app/build.gradle | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/app/build.gradle b/app/build.gradle
index 0913ebc..f621584 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -1,5 +1,4 @@
 apply plugin: 'com.android.application'
-apply plugin: 'checkstyle'
 apply plugin: 'com.neenbedankt.android-apt'
 //apply plugin: 'com.intive.codequality'
 
@@ -44,29 +43,6 @@ android {
    }
 }
 
-task checkstyle(type: Checkstyle) {
-   source 'src/'
-   include '**/*.java'
-   exclude '**/gen/**'
-   classpath = files()
-   reports {
-      xml {
-         destination "build/outputs/reports/checkstyle-results.xml"
-      }
-   }
-}
-
-task checkstyleReport(dependsOn: 'checkstyle') {
-   doLast{
-      if (file("build/outputs/reports/checkstyle-results.xml").exists()) {
-         ant.xslt(in: "build/outputs/reports/checkstyle-results.xml",
-               style: "config/checkstyle/checkstyle.xsl",
-               out: "build/outputs/reports/checkstyle-results.html"
-         )
-      }
-   }
-}
-
 dependencies {
    compile 'com.google.dagger:dagger:2.6.1'
    apt "com.google.dagger:dagger-compiler:2.6.1"