[WIP] Add cloudbuild.yaml and build script for image promotion#986
Closed
dims wants to merge 1 commit intokubernetes-sigs:mainfrom
Closed
[WIP] Add cloudbuild.yaml and build script for image promotion#986dims wants to merge 1 commit intokubernetes-sigs:mainfrom
dims wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Add GCB (Google Cloud Build) configuration to enable image building and promotion via the k8s-staging-images infrastructure, following the same pattern as dra-driver-cpu. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shivamerla
reviewed
Apr 3, 2026
| @@ -0,0 +1,9 @@ | |||
| # See https://cloud.google.com/cloud-build/docs/build-config | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Should we add timeout as well? The default seems to be 10mins and multi-arch builds might exceed that.
shivamerla
reviewed
Apr 3, 2026
| if git describe --exact-match --tags HEAD >/dev/null 2>&1; then | ||
| IMG_TAG=$(git describe --exact-match --tags HEAD) | ||
| else | ||
| IMG_TAG="$(date +v%Y%m%d)-$(git rev-parse --short HEAD)" |
Contributor
There was a problem hiding this comment.
looks like _GIT_TAG is already available, should we pass it as an env same like the IMAGE_PREFIX?
Member
Author
|
@shivamerla can you please take this over :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GCB (Google Cloud Build) configuration to enable image building and promotion via the k8s-staging-images infrastructure, following the same pattern as dra-driver-cpu.