Remove helm value for gpuResourcesEnabledOverride#463
Remove helm value for gpuResourcesEnabledOverride#463klueska wants to merge 6 commits intokubernetes-sigs:mainfrom
Conversation
klueska
force-pushed
the
remove-gpuResourcesEnabledOverride
branch
from
aa5a432 to
155186d
Compare
This is a straight copy of this PR kubernetes-sigs/dra-example-driver#75, with minimal changes to make it work in this repo. Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Previously, the webhook only supported cert-manager with a self-signed issuer for TLS certificate generation and management. With this patch, users can now provide their own TLS certificates via secret mode or use custom cert-manager issuers (issuer/clusterissuer) with specified issuer names. Signed-off-by: Kevin Klues <kklues@nvidia.com>
With this removed, the GPU side of the driver will be enabled by default with no safeguards to ensure that someone explicity sets it to false if that is their actual intention. Signed-off-by: Kevin Klues <kklues@nvidia.com>
klueska
force-pushed
the
remove-gpuResourcesEnabledOverride
branch
from
155186d to
8df56a8
Compare
|
We still need a patch like this for the 25.12.0 release -- correct? (With the 25.12.0 release, we don't want people to have to set CC @shivamerla |
|
No! We still don't want this on by default until the DRA extended resources API is GA in upstream Kubernetes. The change relevant to this release was to change the error message. It was merged here: #809 |
|
Got it. I missed #809 -- the new error message is clear. |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
cncf-cla: yes
|
needs a rebase please! |
5 participants
With this removed, the GPU side of the driver will be enabled by default with no safeguards to ensure that someone explicity sets it to false if that is their actual intention.