Skip to content

refactor: Replace string-based import parsing with AST-based detection #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanoFioravanzo wants to merge 6 commits into
base: main
Choose a base branch
from
+824 −46
Open

refactor: Replace string-based import parsing with AST-based detection #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a352ac
feat: Add AST-based import parsing module
StefanoFioravanzo Feb 2, 2026
ac02654
test: Add comprehensive unit tests for imports module
StefanoFioravanzo Feb 2, 2026
e907eee
refactor: Use AST-based import parsing in compiler
StefanoFioravanzo Feb 2, 2026
74926a4
style: Fix import sorting in test_imports.py
StefanoFioravanzo Feb 4, 2026
695042a
Merge branch 'main' into refactor/ast-based-import-detection
StefanoFioravanzo Feb 4, 2026
965e4f4
style: Apply ruff lint fixes for modern Python type annotations
StefanoFioravanzo Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions backend/kale/common/astutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ def get_list_tuple_names(node):
Returns: a list of all names of the tuple

"""
assert isinstance(node, (ast.Tuple, ast.List))
assert isinstance(node, ast.Tuple | ast.List)
names = []
for _n in node.elts:
if isinstance(_n, (ast.Tuple, ast.List)):
if isinstance(_n, ast.Tuple | ast.List):
# recursive call
names.extend(get_list_tuple_names(_n))
elif isinstance(_n, (ast.Name,)):
elif isinstance(_n, ast.Name):
names.append(_n.id)
return names

Expand Down Expand Up @@ -135,21 +135,18 @@ def get_marshal_candidates(code):
for node in walk(block, stop_at=contexts):
if isinstance(node, contexts):
names.add(node.name)
if isinstance(node, (ast.Name,)):
if isinstance(node, ast.Name):
names.add(node.id)
if isinstance(
node,
(
ast.Import,
ast.ImportFrom,
),
ast.Import | ast.ImportFrom,
):
for _n in node.names:
if _n.asname is None:
names.add(_n.name)
else:
names.add(_n.asname)
if isinstance(node, (ast.Tuple, ast.List)):
if isinstance(node, ast.Tuple | ast.List):
names.update(get_list_tuple_names(node))
return names

Expand All @@ -171,7 +168,7 @@ def parse_functions(code):
tree = ast.parse(code)
for block in tree.body:
for node in walk(block, stop_at=(ast.FunctionDef,), ignore=(ast.ClassDef,)):
if isinstance(node, (ast.FunctionDef,)):
if isinstance(node, ast.FunctionDef):
fn_name = node.name
fns[fn_name] = astor.to_source(node)
return fns
Expand Down Expand Up @@ -208,7 +205,7 @@ def get_function_calls(code):
# a function call. We check the attribute func to be ast.Name
# because it could also be a ast.Attribute node, in case of
# function calls like obj.foo()
if isinstance(node, (ast.Call,)) and isinstance(node.func, (ast.Name,)):
if isinstance(node, ast.Call) and isinstance(node.func, ast.Name):
fns.add(node.func.id)
return fns

Expand All @@ -230,10 +227,7 @@ def get_function_and_class_names(code):
for node in walk(block):
if isinstance(
node,
(
ast.FunctionDef,
ast.ClassDef,
),
ast.FunctionDef | ast.ClassDef,
):
names.add(node.name)
return names
Expand All @@ -256,10 +250,7 @@ def parse_assignments_expressions(code):
if (
isinstance(
targets[0],
(
ast.Tuple,
ast.List,
),
ast.Tuple | ast.List,
)
or len(targets) > 1
):
Expand Down
Loading