Skip to content

Issue 539 - Remove Marshaller logs from the HTML Artifacts #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ada333 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

Issue 539 - Remove Marshaller logs from the HTML Artifacts #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backend/kale/marshal/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class that extends the base `MarshalBackend`. `Dispatcher` calls
saved file.
"""
abs_path = os.path.join(get_data_dir(), name + "." + self.file_type)
log.info(
log.debug(
"Saving %s object using %s: %s to %s", self.display_name, self.name, name, abs_path
)
try:
Expand Down Expand Up @@ -124,7 +124,7 @@ class that extends the base `MarshalBackend`. `Dispatcher` calls
directly this function instead of `load`.
"""
abs_path = os.path.join(get_data_dir(), name + "." + self.file_type)
log.info("Loading %s file using %s: %s", self.display_name, self.name, name)
log.debug("Loading %s file using %s: %s", self.display_name, self.name, name)
try:
return self.load(abs_path)
except ImportError as e:
Expand Down Expand Up @@ -285,9 +285,9 @@ def _unique_ls(basename: str):
and os.path.splitext(ls)[0] == basename
)
]
log.info("Found %d entries for basename '%s': %s", len(entries), basename, entries)
log.debug("Found %d entries for basename '%s': %s", len(entries), basename, entries)
if not entries:
log.info(
log.debug(
"Looking for unique file/folder with basename '%s' in %s", basename, get_data_dir()
)
raise ValueError(
Expand Down
2 changes: 1 addition & 1 deletion backend/kale/templates/new_nb_function_template.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def {{ step.name }}_step({{ component_signature_args }}):
_kale_marshal.set_data_dir("/marshal")
{%- for output_art in step_outputs %}
# Save {{ output_art.name }} to output artifact
_kale_marshal.save({{ output_art.name }}, "{{ output_art.name }}_artifact")
_ = _kale_marshal.save({{ output_art.name }}, "{{ output_art.name }}_artifact")
{%- endfor %}
# -----------------------DATA SAVING END-----------------------------------
'''
Expand Down
10 changes: 5 additions & 5 deletions backend/kale/tests/assets/kfp_dsl/iris.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ def load_transform_data_step(load_transform_data_html_report: Output[HTML], x_tr
from kale import marshal as _kale_marshal
_kale_marshal.set_data_dir("/marshal")
# Save x_trn to output artifact
_kale_marshal.save(x_trn, "x_trn_artifact")
_ = _kale_marshal.save(x_trn, "x_trn_artifact")
# Save x_tst to output artifact
_kale_marshal.save(x_tst, "x_tst_artifact")
_ = _kale_marshal.save(x_tst, "x_tst_artifact")
# Save y_trn to output artifact
_kale_marshal.save(y_trn, "y_trn_artifact")
_ = _kale_marshal.save(y_trn, "y_trn_artifact")
# Save y_tst to output artifact
_kale_marshal.save(y_tst, "y_tst_artifact")
_ = _kale_marshal.save(y_tst, "y_tst_artifact")
# -----------------------DATA SAVING END-----------------------------------
'''

Expand Down Expand Up @@ -152,7 +152,7 @@ def train_model_step(train_model_html_report: Output[HTML], x_trn_input_artifact
from kale import marshal as _kale_marshal
_kale_marshal.set_data_dir("/marshal")
# Save model to output artifact
_kale_marshal.save(model, "model_artifact")
_ = _kale_marshal.save(model, "model_artifact")
# -----------------------DATA SAVING END-----------------------------------
'''

Expand Down
2 changes: 1 addition & 1 deletion backend/kale/tests/assets/kfp_dsl/pipeline_parameters_and_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def create_matrix_step(create_matrix_html_report: Output[HTML], rnd_matrix_outpu
from kale import marshal as _kale_marshal
_kale_marshal.set_data_dir("/marshal")
# Save rnd_matrix to output artifact
_kale_marshal.save(rnd_matrix, "rnd_matrix_artifact")
_ = _kale_marshal.save(rnd_matrix, "rnd_matrix_artifact")
# -----------------------DATA SAVING END-----------------------------------
'''

Expand Down