[Model Sync Controller] Remove post processing of the kubebuilder CRD

[jlewi]

We currently post-process the CRD generated by kubebuilder here

code-intelligence/Label_Microservice/go/Makefile

Line 55 in 7f51416

python ./hack/prune_crd.py ./config/crd/bases/automl.cloudai.kubeflow.org_modelsyncs.yaml

This post-processing removes validation for PipelineRunRef and just treats it as an arbitrary json.

This is undesirable because we'd like validation to insure PipelineRunRef's are correct.

This was necessary because PipelineParams implement custom marshling and kubebuilder didn't handle this correctly at the time.

This should be fixed by kubernetes-sigs/controller-tools#427 which should be in controller-gen 0.3.0 and later.

I think I'm currently using v0.2.5. We should try to upgrade and see if that fixes the issue and get rid of our postprocessing.

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
kind/feature	0.63

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.