From cb5465a72d265dc72ab826658c62f20cffa1dce1 Mon Sep 17 00:00:00 2001
From: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Date: Sat, 16 Dec 2023 16:45:37 +0000
Subject: [PATCH] vuln-fix: Use HTTPS instead of HTTP to resolve deps
 CVE-2021-26291

This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Weakness: CWE-829: Inclusion of Functionality from Untrusted Control Sphere
Severity: High
CVSS: 8.1
Detection: CodeQL & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/) & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8


Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/IfHkrYfxx?organizationId=QWxsIEdpdEh1Yg%3D%3D

Co-authored-by: Moderne <team@moderne.io>
---
 spring-fileupload-tutorial/pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/spring-fileupload-tutorial/pom.xml b/spring-fileupload-tutorial/pom.xml
index c176c8e..bec6f7b 100644
--- a/spring-fileupload-tutorial/pom.xml
+++ b/spring-fileupload-tutorial/pom.xml
@@ -243,7 +243,7 @@
 	<repository>
 		<id>org.springframework.maven.release</id>
 		<name>Spring Maven Release Repository</name>
-		<url>http://maven.springframework.org/release</url>
+		<url>https://maven.springframework.org/release</url>
 		<releases><enabled>true</enabled></releases>
 		<snapshots><enabled>false</enabled></snapshots>
 	</repository>
@@ -252,7 +252,7 @@
 	<repository>
 		<id>org.springframework.maven.snapshot</id>
 		<name>Spring Maven Snapshot Repository</name>
-		<url>http://maven.springframework.org/snapshot</url>
+		<url>https://maven.springframework.org/snapshot</url>
 		<releases><enabled>false</enabled></releases>
 		<snapshots><enabled>true</enabled></snapshots>
 	</repository> 
@@ -261,7 +261,7 @@
 	<repository>
 		<id>org.springframework.maven.milestone</id>
 		<name>Spring Maven Milestone Repository</name>
-		<url>http://maven.springframework.org/milestone</url>
+		<url>https://maven.springframework.org/milestone</url>
 		<snapshots><enabled>false</enabled></snapshots>
 	</repository>