LocalSocketListener security

[NuSkooler]

I have implemented a PoC level pipe/UNIX domain socket system using LocalSocketListener. My next step is to secure the domain socket/pipes. Is this possible with this implementation or must I use the lower level OS-specific calls? I'd certainly prefer to have a generic code path with as little target_os checks as possible.

• Windows: Set the security descriptor
• Linux: File permissions

// how to secure ipc_listener?
let ipc_listener = LocalSocketListener::bind(local_ipc_name.clone())?;

[kotauskas]

On Linux, the created socket file obeys usual umask() logic. None of the calls performed by Interprocess take the mode as an input. On Windows, PipeListenerOptions on named pipes allows using a custom security descriptor (this requires unsafe code, and I might overhaul it a bit in the following commits).

Adding a local_socket::ListenerOptions that reads certain parameters and ignores ones not applicable to the current system seems like the most ergonomic choice to me. I haven't considered it before, but permissions sound like good enough motivation for it to be a thing.

[NuSkooler]

@kotauskas Thanks for your quick reply! ListenerOptions on local_socket sounds great. Any way I can help?

[kotauskas]

Because the APIs are currently in rapid motion in preparation for 2.0.0 (I'm consolidating all previously planned breaking changes), now is an inopportune time for PRs. This should be over in a few weeks depending on how much free time I'll get to spend on this.

[NuSkooler]

Thanks, I'll keep an eye out - what's the 2.0 ETA?

[kotauskas]

@NuSkooler 2.0.0 is now out (in fact, 2.1.0 is the most recent version), and both Windows security descriptors and Unix file modes are now supported.

[NuSkooler]

Great, thank you!