From fabdbf453133b791f8ec7af5cb1882d54761d176 Mon Sep 17 00:00:00 2001 From: John Yani Date: Fri, 1 Jul 2016 00:30:08 +0300 Subject: [PATCH] Do not use VOLUME If you specify a volume in Dockerfile, it would be impossible to remove/override it using options. Moreover, it would leave dangling volumes for inexperienced users and users of docker-compose. In docker-compose, you wouldn't be able to specify mounted volume. Please let the user specify the volume location. --- alpine-mariadb/Dockerfile | 2 -- 1 file changed, 2 deletions(-) diff --git a/alpine-mariadb/Dockerfile b/alpine-mariadb/Dockerfile index 9e2e6ab..41506a0 100644 --- a/alpine-mariadb/Dockerfile +++ b/alpine-mariadb/Dockerfile @@ -12,7 +12,5 @@ chmod -R 755 /scripts EXPOSE 3306 # WORKDIR /app -VOLUME ["/var/lib/mysql"] - ENTRYPOINT ["/scripts/run.sh"]