Tear down

[knownasilya]

Do we really need to unhighlight on teardown? Seems like it's extra/unnecessary work.

Any users have thoughts on this?

[villander]

@knownasilya i installed this addon, but he not working with ember-cli 2.5.0. :(

[knownasilya]

Thanks for letting me know. Were there any errors?

[villander]

@knownasilya i not found any errors! Just not working.
I will investigate further. if I find any trace I warn :D

[knownasilya]

Are you sure it's the version of ember-cli and not of Ember itself?

[villander]

I do not know, but if we do upgrade cli consequently the ember will together. The worst is that there appears no error or warning.

I will try make update in Ember first.

[villander]

@knownasilya how use a addon without public it?

I want test in localhost with my project

[knownasilya]

you can npm link the addon. Inside your project do npm link ../ember-highlight (adjust path to your fs).

[villander]

I did update of Ember. but not back works. Now will update ember-cli of

[villander]

@knownasilya your addon works with ember-cli 2.5.0
Only in a project of my company that is not working, but the problem is with the project.
I created several test projects and its addon worked perfectly.

But I was analyzing the code of your addon and I made some improvements of good practice. Look #5 please

[petey]

@knownasilya I consistently get errors with this module (v.1.2.6) on ember 2.18.2, specifically when it calls unhighlight. Version 1.2.5 works fine.

component.js:63 Uncaught TypeError: this.$(...).unhighlight is not a function
    at Class.unhighlight (component.js:63)
    at Class.<anonymous> (component.js:30)
    at invoke (backburner.js:258)
    at Queue.flush (backburner.js:151)
    at DeferredActionQueues.flush (backburner.js:329)
    at Backburner.end (backburner.js:462)
    at Backburner._run (backburner.js:833)
    at Backburner._join (backburner.js:809)
    at Backburner.join (backburner.js:529)
    at Function.run.join (ember-metal.js:4453)

    unhighlight: function unhighlight() {
      if (this.$()) {
->      this.$().unhighlight();
      }
    }

[knownasilya]

I'll add an extra check there to prevent errors, but seems like something isn't working properly.

[knownasilya]

Fix should be in v1.2.7

[petey]

I have the same issue, except now for calls to highlight. It doesn't appear that jquery-highlight is being included as a dependency at all.

[knownasilya]

What version of ember-cli are you running?