Bugs?

[davidquintard]

Hi there
I dont understand this function.
Param currentUser is unused
Variable users is undeclared : "or (let x in users) {"

let getContacts = currentUser => {
		return new Promise((resolve, reject) => {
			db.collection('users').find({

			}).toArray((err, data) => {
				if (err) {
					reject();
					return console.log(err);
				}
				if (!data || !data[0]) {
					resolve([]);
					return;
				}

				let contacts = data.map(contact => {
					let online = false;

					for (let x in users) {
						if (users[x].id == contact._id) {
							online = true;
							break;
						}
					}
					return {
						id: contact._id + '',
						name: contact.name,
						username: contact.username,
						image: contact.image,
						online: online
					};
				});
				resolve(contacts);

			});
		});
	};

[therealjimwolff]

Let x in users iterates over the users array, x representing the current user being iterated. If you aren't connected to the server (and it to MONGODB) and have accounts created, there won't be any and the array will be empty.