Skip to content

fix: check win properties in browser code paths for react native #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaswhyyou merged 2 commits into from
Jan 15, 2026
Merged

fix: check win properties in browser code paths for react native #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4810d9a
guard browser code paths based on win properties in addition to win o…
thomaswhyyou Jan 15, 2026
bb918d6
changeset
thomaswhyyou Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-berries-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@knocklabs/client": patch
---

[guides] check window properties in browser specific code paths for react native
10 changes: 5 additions & 5 deletions packages/client/src/clients/guide/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const guidesApiRootPath = (userId: string | undefined | null) =>
// Detect debug params from URL or local storage
const detectDebugParams = (): DebugState => {
const win = checkForWindow();
if (!win) {
if (!win || !win.location) {
return { forcedGuideKey: null, previewSessionId: null };
}

Expand Down Expand Up @@ -287,7 +287,7 @@ export class KnockGuideClient {
} = options;
const win = checkForWindow();

const location = trackLocationFromWindow ? win?.location.href : undefined;
const location = trackLocationFromWindow ? win?.location?.href : undefined;

const debug = detectDebugParams();

Expand Down Expand Up @@ -552,7 +552,7 @@ export class KnockGuideClient {

// Remove URL query params if present
// Only update the URL if params need to be cleared to avoid unnecessary navigations
if (win) {
if (win?.location) {
const url = new URL(win.location.href);
if (
url.searchParams.has(DEBUG_QUERY_PARAMS.GUIDE_KEY) ||
Expand Down Expand Up @@ -1192,7 +1192,7 @@ export class KnockGuideClient {

private listenForLocationChangesFromWindow() {
const win = checkForWindow();
if (win?.history) {
if (win?.history && win?.addEventListener) {
// 1. Listen for browser back/forward button clicks.
win.addEventListener("popstate", this.handleLocationChange);

Expand Down Expand Up @@ -1233,7 +1233,7 @@ export class KnockGuideClient {

removeLocationChangeEventListeners() {
const win = checkForWindow();
if (!win?.history) return;
if (!win?.history || !win?.removeEventListener) return;

win.removeEventListener("popstate", this.handleLocationChange);
win.removeEventListener("hashchange", this.handleLocationChange);
Expand Down
Loading