-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
claudeCreated or actioned by Claude AICreated or actioned by Claude AIupstream-syncIssues for syncing updates with our upstream (cocoindex-io/cocoindex)Issues for syncing updates with our upstream (cocoindex-io/cocoindex)
Description
Upstream Change Summary
Type: bug-fix / improvement
Difficulty: Easy
Recommendation: Adopt
Upstream changed the list() method for the LocalFile source to ignore all errors during directory listing and emit warnings instead of propagating errors. Previously, a single unreadable file or permission error could abort the entire listing. This makes the source more resilient when processing directories with mixed permissions.
Upstream References
- PR: chore: ignore all errors and warn in
list()forLocalFilesource cocoindex-io/cocoindex#1753 (commit: be49b878) - Release: v0.3.35
- Upstream repo: https://github.com/cocoindex-io/cocoindex
Relevant Upstream Files / Areas
rust/cocoindex/src/ops/sources/local_file.rs—list()method error handling
Recoco Considerations
- Maps to
crates/recoco-core/src/ops/sources/local_file.rs(or equivalent path) - Feature-gated behind
source-local-file— no new feature gates needed - This change is purely in error handling logic, no API surface changes
- Recoco uses the same local_file source implementation; this fix is directly applicable
- Consider whether tracing/log crate integration aligns with recoco's logging approach (recoco may use
tracing— ensure warnings usetracing::warn!notlog::warn!)
Integration Notes
Simple and safe to adopt. Check that the list() function signature and surrounding code in recoco's local_file source matches the upstream before applying the patch. Related to filesystem watch support (issue #97) — both touch the same source file.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
claudeCreated or actioned by Claude AICreated or actioned by Claude AIupstream-syncIssues for syncing updates with our upstream (cocoindex-io/cocoindex)Issues for syncing updates with our upstream (cocoindex-io/cocoindex)