-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
claudeCreated or actioned by Claude AICreated or actioned by Claude AIupstream-syncIssues for syncing updates with our upstream (cocoindex-io/cocoindex)Issues for syncing updates with our upstream (cocoindex-io/cocoindex)
Description
Upstream Change Summary
Type: architectural-change (refactor)
Difficulty: Easy
Recommendation: Adopt
Two related upstream refactors reorganized rust/ops_text/:
- PR #1751: Moved
output_positions.rsfromsplit/to the crate root ofops_text - PR #1752: Moved more elements out of the
splitmodule (by_separators, recursive splitters) to reduce module nesting
These are purely structural changes with no behavioral impact, but recoco-splitters should mirror the upstream module layout for easier future sync.
Upstream References
- PR #1751: refactor: move
output_positions.rsto crate root cocoindex-io/cocoindex#1751 (moveoutput_positions.rsto crate root) - PR #1752: refactor: move more elements out of
splitmodule cocoindex-io/cocoindex#1752 (move more elements out ofsplitmodule) - Release: v0.3.35
- Upstream repo: https://github.com/cocoindex-io/cocoindex
Relevant Upstream Files / Areas
rust/ops_text/src/output_positions.rs— moved to crate rootrust/ops_text/src/split/mod.rs— elements moved outrust/ops_text/src/split/by_separators.rsrust/ops_text/src/split/recursive.rsrust/ops_text/src/lib.rs— updated re-exports
Recoco Considerations
- Maps to
crates/recoco-splitters - This is distinct from issue [upstream-sync] Move pattern-matcher module from core to splitters #96 (PatternMatcher move) — these are different structural changes within
ops_text/recoco-splitters - Low risk, purely structural — update
mod.rsandlib.rsre-exports accordingly - Verify public API surface of
recoco-splittersis unchanged after re-export updates - No feature-gating changes required
Integration Notes
Both PRs were merged on the same day (2026-03-11) and are clearly a coordinated cleanup. Apply them together. Check if any downstream code in recoco imports from the old module paths and update accordingly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
claudeCreated or actioned by Claude AICreated or actioned by Claude AIupstream-syncIssues for syncing updates with our upstream (cocoindex-io/cocoindex)Issues for syncing updates with our upstream (cocoindex-io/cocoindex)