From 32ee6dc0d791a077a360890b099f210ca9148767 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Fri, 13 Mar 2026 02:33:36 +0000
Subject: [PATCH 1/2] perf(graph): optimize duplicate export detection in
 own_exports

Replaces the O(N^2) duplicate detection logic in `PropagationGraph._validate_no_duplicates` (which used `export_names.count(name)` inside a list comprehension) with an O(N) approach using `collections.Counter(export_names)`. This significantly improves the performance of validation for large module graphs.

Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
---
 src/exportify/export_manager/graph.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/exportify/export_manager/graph.py b/src/exportify/export_manager/graph.py
index ce272f2..fa5f159 100644
--- a/src/exportify/export_manager/graph.py
+++ b/src/exportify/export_manager/graph.py
@@ -13,6 +13,7 @@
 
 from __future__ import annotations
 
+import collections
 from dataclasses import dataclass, field
 from enum import IntEnum
 from typing import TYPE_CHECKING, Literal
@@ -289,7 +290,7 @@ def _validate_no_duplicates(self) -> None:
             # Check for duplicates in own_exports
             export_names = list(node.own_exports.keys())
             if len(export_names) != len(set(export_names)):
-                duplicates = [name for name in export_names if export_names.count(name) > 1]
+                duplicates = [name for name, count in collections.Counter(export_names).items() if count > 1]
                 raise ValueError(
                     f"❌ Error: Duplicate exports in module {module_path}\n\n"
                     f"  Duplicates: {', '.join(set(duplicates))}"

From 042557bbb3ef31a62381632b5d92339455d765fd Mon Sep 17 00:00:00 2001
From: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Date: Thu, 12 Mar 2026 23:43:05 -0400
Subject: [PATCH 2/2] Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
---
 src/exportify/export_manager/graph.py | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/src/exportify/export_manager/graph.py b/src/exportify/export_manager/graph.py
index fa5f159..a1902c1 100644
--- a/src/exportify/export_manager/graph.py
+++ b/src/exportify/export_manager/graph.py
@@ -285,16 +285,21 @@ def _add_propagated_export(self, node: ModuleNode, entry: ExportEntry) -> None:
             node.propagated_exports[name] = entry
 
     def _validate_no_duplicates(self) -> None:
-        """Validate no duplicate exports in same module."""
-        for module_path, node in self.modules.items():
-            # Check for duplicates in own_exports
-            export_names = list(node.own_exports.keys())
-            if len(export_names) != len(set(export_names)):
-                duplicates = [name for name, count in collections.Counter(export_names).items() if count > 1]
-                raise ValueError(
-                    f"❌ Error: Duplicate exports in module {module_path}\n\n"
-                    f"  Duplicates: {', '.join(set(duplicates))}"
-                )
+        """Validate no duplicate exports in same module.
+
+        Notes
+        -----
+        `ModuleNode.own_exports` is a `dict` keyed by export name, so it
+        cannot contain duplicate keys by construction: inserting the same
+        name multiple times will simply overwrite the previous entry.
+
+        As a result, detecting duplicates by inspecting
+        `node.own_exports.keys()` can never succeed. If duplicate detection
+        is required, it must be implemented at insertion time (for example,
+        in the code that populates `own_exports`) *before* overwriting any
+        existing entry.
+        """
+        return
 
     def _validate_propagation_sources(self) -> None:
         """Validate all propagated exports have valid source modules."""