Skip to content

Fixed parsing of 'sort' when containing '=' character #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flmg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed parsing of 'sort' when containing '=' character #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c0617
[UPDATE] parsing sort with regex
flmg Dec 27, 2017
12d800c
[FIX] case where match is undefined
flmg Dec 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonApiQueryParser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class JsonApiQueryParser {
*
**/
static parseSort (sortString, requestDataSubset) {
let targetString = sortString.split('=')[1];
let targetString = sortString.split(/=(.+)/)[1] || '';
requestDataSubset.sort = targetString.split(',');

return requestDataSubset;
Expand Down
22 changes: 22 additions & 0 deletions test/JsonApiQueryParser.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,28 @@ describe('JsonApiQueryParser', function () {

expect(testData).to.deep.equal(expectedData);
});

it('should parse a sort value containing an \'=\' character', function() {
let sortString = 'sort=-(value1=test),value2';

let testData = JsonApiQueryParser.parseSort(sortString, requestDataSubset);
let expectedData = {
include: [],
fields: {},
sort: ['-(value1=test)', 'value2'],
page: {},
filter: {
like: {},
not: {},
lt: {},
lte: {},
gt: {},
gte: {}
}
};

expect(testData).to.deep.equal(expectedData);
});
});

describe('parseFilter function', function() {
Expand Down