From e8d546bd7ce88986cdb0363aead5ad868d3443dd Mon Sep 17 00:00:00 2001 From: Andri Alexandrou Date: Mon, 27 Jan 2025 11:12:48 -0800 Subject: [PATCH 1/3] fix: applies alt text only once --- src/utils.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/utils.js b/src/utils.js index 76382aa..c015610 100644 --- a/src/utils.js +++ b/src/utils.js @@ -23,11 +23,7 @@ export function appendAccessibilityInfo() { document.querySelectorAll(".markdown-body").forEach(function (commentBody) { commentBody.querySelectorAll("img").forEach(function (image) { - const parentNodeName = image.parentElement.nodeName; - if (parentNodeName === "A" || parentNodeName === "P") { - const parent = image.closest("a") || image.closest("p"); - validateImages(parent, image); - } + validateImages(image.closest("a") || image.closest("p"), image); }); commentBody From 9af937f2ec064953aeea4fb4b4a6bce95ce78c6b Mon Sep 17 00:00:00 2001 From: Andri Alexandrou Date: Mon, 27 Jan 2025 11:21:56 -0800 Subject: [PATCH 2/3] Add check for existing image caption. --- src/utils.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/utils.js b/src/utils.js index c015610..4357803 100644 --- a/src/utils.js +++ b/src/utils.js @@ -101,6 +101,9 @@ function validateImagesWithAnchorParent(parent, image) { image.classList.add("github-a11y-img-invalid-alt"); } + if (parent.querySelector('.github-a11y-img-caption')) { + return; + } const subtitle = createSubtitleElement(); parent.classList.add("github-a11y-img-container"); @@ -123,6 +126,9 @@ function validateImagesWithNonAnchorParent(parent, image) { if (invalidAltText(altText)) { image.classList.add("github-a11y-img-invalid-alt"); } + if (parent.querySelector('.github-a11y-img-caption')) { + return; + } const subtitle = createSubtitleElement(); parent.classList.add("github-a11y-img-container"); From bd137c05fd385b3d0de0b18550ad39cfbb208991 Mon Sep 17 00:00:00 2001 From: Andri Alexandrou Date: Mon, 27 Jan 2025 11:24:08 -0800 Subject: [PATCH 3/3] revert --- src/utils.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/utils.js b/src/utils.js index 4357803..b6048f0 100644 --- a/src/utils.js +++ b/src/utils.js @@ -23,7 +23,11 @@ export function appendAccessibilityInfo() { document.querySelectorAll(".markdown-body").forEach(function (commentBody) { commentBody.querySelectorAll("img").forEach(function (image) { - validateImages(image.closest("a") || image.closest("p"), image); + const parentNodeName = image.parentElement.nodeName; + if (parentNodeName === "A" || parentNodeName === "P") { + const parent = image.closest("a") || image.closest("p"); + validateImages(parent, image); + } }); commentBody