From 526838000464d1cccb29009290302e15b1820ccc Mon Sep 17 00:00:00 2001
From: Juan Ramos <juancagb.17@gmail.com>
Date: Thu, 7 Oct 2021 23:51:26 -0500
Subject: [PATCH] Fix form action, Make some texts more clear, Fix indentation,
 Add page title

---
 .gitignore      |  1 +
 1/form_.php     |  2 +-
 1/index.php     |  7 ++++---
 1/welcome.php   |  4 ++--
 1/welcome_.php  | 50 ++++++++++++++++++++++++++-----------------------
 2/Palindorm.php | 32 +++++++++++++++++--------------
 6 files changed, 53 insertions(+), 43 deletions(-)
 create mode 100644 .gitignore
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..62c8935
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.idea/
\ No newline at end of file
diff --git a/1/form_.php b/1/form_.php
index 5e7e84d..058dc72 100644
--- a/1/form_.php
+++ b/1/form_.php
@@ -4,7 +4,7 @@
 	<title></title>
 </head>
 <body>
-	<form action="welcome_.php" action="get">
+	<form action="welcome_.php" method="get">
 		<input type="email" name="email">
 		<input type="password" name="password">
 		<input type="submit">
diff --git a/1/index.php b/1/index.php
index 7244f84..04b87b6 100644
--- a/1/index.php
+++ b/1/index.php
@@ -1,4 +1,5 @@
 <?php
-echo "hello keshav";
-include 'welcome.php';
-?>
\ No newline at end of file
+
+echo "Hello, keshav";
+
+include 'welcome.php';
\ No newline at end of file
diff --git a/1/welcome.php b/1/welcome.php
index 48b4af8..b972b00 100644
--- a/1/welcome.php
+++ b/1/welcome.php
@@ -1,3 +1,3 @@
 <?php
-echo "pkkkkkkkk";
-?>
\ No newline at end of file
+
+echo "Welcome message (included)";
diff --git a/1/welcome_.php b/1/welcome_.php
index edaeaf1..b2f08fe 100644
--- a/1/welcome_.php
+++ b/1/welcome_.php
@@ -1,34 +1,38 @@
 <?php
-$email=$_GET['email'];
-$password=$_GET['password'];
-echo "email = ".$email."; password = ".$password;
+    $email = $_GET['email'];
+    $password = $_GET['password'];
+    echo "Email = ".$email."; Password = ".$password;
 ?>
+
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
-	<title></title>
+	<title>PHP Example</title>
 </head>
 <body>
 	<form>
-		<h4>Retrive Email</h4>
-		<input type="email" value="<?php echo $email ?>"><br>
-		<h4>Retrive Password</h4>
+		<h4>Retrieve Email</h4>
+		<input type="email" value="<?php echo $email ?>">
+        
+        <br>
+        
+		<h4>Retrieve Password</h4>
 		<input type="password" value="<?php echo $_GET["password"] ?>" class="password">
 	</form>
-<script>
-	var x=document.querySelector('.password')
-	var y=document.querySelector('input')
-	y.style.borderColor='red'
-	if(x.value=='')
-	{
-		x.type='text'
-		x.value='password is empty'
-		x.style.color='red'
-	}
-	else
-	{
-		x.style.color='green'
-	}
-</script>
+
+    <script>
+        const x = document.querySelector('.password');
+        const y = document.querySelector('input');
+        
+        y.style.borderColor='red';
+        
+        if (x.value === '') {
+            x.type='text'
+            x.value='password is empty'
+            x.style.color='red'
+        } else {
+            x.style.color='green'
+        }
+    </script>
 </body>
 </html>
\ No newline at end of file
diff --git a/2/Palindorm.php b/2/Palindorm.php
index 5dc93ed..6b6938a 100644
--- a/2/Palindorm.php
+++ b/2/Palindorm.php
@@ -1,20 +1,24 @@
-<form method="post">        
-Enter a Number: <input type="text" name="num"/><br>  
-<button type="submit">Check</button>  
-</form>  
+<form method="post">
+    <label for="num">Enter a Number:</label>
+    <input type="text" name="num" id="num">
+    
+    <button type="submit">Check</button>  
+</form>
+
 <?php   
     if($_POST)  
     {  
-        //get the value from form  
-        $num = $_POST['num'];  
-        //reversing the number  
+        // Get number from form  
+        $num = $_POST['num'];
+        
+        // Reverse the number  
         $reverse = strrev($num);  
           
-        //checking if the number and reverse is equal  
-        if($num == $reverse){  
-            echo "The number $num is Palindrome";     
-        }else{  
+        // Check if the number and reverse are equal  
+        if ($num == $reverse) {  
+            echo "The number $num is a Palindrome";     
+        } else {  
             echo "The number $num is not a Palindrome";   
-        }  
-}     
-      ?>  
\ No newline at end of file
+    }  
+}
+?>  
\ No newline at end of file
