Skip to content

Package update #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kernelcoffee merged 5 commits into from
Jan 16, 2026
Merged

Package update #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e48d824
Update to node 22
kernelcoffee Jan 15, 2026
517d7ef
Update to react 19
kernelcoffee Jan 15, 2026
0f3d64d
update to node 24
kernelcoffee Jan 15, 2026
1e79017
Update esling to 7 and react-routeur
kernelcoffee Jan 16, 2026
5729dbb
Upgrade Tailwind CSS to version 4
kernelcoffee Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '24'
cache: 'npm'
cache-dependency-path: frontend/package-lock.json

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# -----------------------------------------------------------------------------
# Stage 1: Build Frontend
# -----------------------------------------------------------------------------
FROM node:20-alpine AS frontend-build
FROM node:24-alpine AS frontend-build

WORKDIR /frontend

Expand Down
37 changes: 37 additions & 0 deletions docs/TOFIX.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Technical Debt & Known Issues

This document tracks disabled warnings, skipped tests, and other technical debt that should be addressed in the future.

## ESLint Rules Disabled

### Frontend (`frontend/eslint.config.js`)

| Rule | Reason | Files Affected |
|------|--------|----------------|
| `react-hooks/set-state-in-effect` | False positives for valid patterns (initializing form state from fetched data, countdown timers) | `Settings.tsx`, `Dashboard.tsx` |

**Details:**
- `Settings.tsx`: Initializes form state when settings data is fetched - standard pattern for forms with async data
- `Dashboard.tsx`: Updates countdown timer state every second - valid use of setInterval in useEffect

## Skipped Tests

### Backend

| Test File | Tests Skipped | Reason |
|-----------|---------------|--------|
| `test_api_main.py` | 2 | Requires database setup - covered by e2e tests |
| `test_scheduler_api.py` | 12 (entire file) | APScheduler causes event loop conflicts in test suite - covered by unit tests |
| `integration/*` | All | Requires `--run-integration` flag and valid PHPSESSID |

**Test counts (as of last run):**
- Backend: 718 passed, 31 skipped
- Frontend: 170 passed, 0 skipped

## Future Improvements

### Code Quality

- [ ] Re-enable `react-hooks/set-state-in-effect` after refactoring affected components
- [ ] Fix APScheduler event loop conflicts to enable scheduler e2e tests in CI
- [ ] Add more integration test coverage with mocked external services
18 changes: 0 additions & 18 deletions frontend/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion frontend/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
24
30 changes: 30 additions & 0 deletions frontend/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import js from '@eslint/js';
import globals from 'globals';
import tseslint from 'typescript-eslint';
import reactHooks from 'eslint-plugin-react-hooks';
import reactRefresh from 'eslint-plugin-react-refresh';

export default tseslint.config(
{ ignores: ['dist', 'coverage'] },
{
extends: [js.configs.recommended, ...tseslint.configs.recommended],
files: ['**/*.{ts,tsx}'],
languageOptions: {
ecmaVersion: 2020,
globals: globals.browser,
},
plugins: {
'react-hooks': reactHooks,
'react-refresh': reactRefresh,
},
rules: {
...reactHooks.configs.recommended.rules,
'react-refresh/only-export-components': [
'warn',
{ allowConstantExport: true },
],
// Disable overly strict rules for valid patterns
'react-hooks/set-state-in-effect': 'off',
},
}
);
Loading