-
-
Notifications
You must be signed in to change notification settings - Fork 281
fix : Question section and Prev/Next Cards #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Gagan202005 <gagansinghal2005@gmail.com>
|
hi @Achanandhi-M @nehagup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the documentation footer UI by redesigning the support section and Prev/Next navigation. The changes focus on reducing visual clutter and creating clearer separation between page sections.
Changes:
- Refactored the KeployCloud support section into a compact horizontal strip with direct links
- Added horizontal dividers between content sections, support strip, navigation, and footer
- Wrapped the DocPaginator in a custom class for styling overrides
- Added CSS rules to create a more compact, bordered pagination design
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/theme/DocItem/index.js | Added horizontal dividers and wrapped paginator with custom class for styling |
| src/components/KeployCloud.js | Converted large card-style support section to compact horizontal strip with links |
| src/css/custom.css | Added custom CSS rules for compact paginator styling with borders |
| src/theme/DocItem/styles.module.css | Added empty lines (no functional changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
|
|
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary blank lines added at the end of the file. These don't add any functional value and should be removed to keep the file clean.
| .keploy-doc-paginator { | ||
| margin-top: 1.5rem; | ||
| padding-top: 1rem; | ||
| border-top: 1px solid var(--ifm-color-emphasis-200); |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .keploy-doc-paginator class has a border-top style (line 2606 in custom.css), but there's already an hr element immediately before the paginator (line 252 in DocItem/index.js). This creates redundant visual separation. Consider removing either the hr element or the border-top style from the CSS to avoid double borders.
| border-top: 1px solid var(--ifm-color-emphasis-200); |
| <KeployCloud /> | ||
|
|
||
| <hr className="my-8 border-[color:var(--ifm-toc-border-color)]" /> | ||
|
|
||
| <div className="keploy-doc-paginator"> | ||
| <DocPaginator previous={metadata.previous} next={metadata.next} /> | ||
| </div> | ||
|
|
||
| <hr className="my-6 border-[color:var(--ifm-color-emphasis-200)]" /> | ||
|
|
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSX elements added here have inconsistent indentation. Lines 250-258 are not properly indented to match the surrounding code structure. They should be indented to align with the parent container's content (same level as the closing article tag on line 247). Proper indentation improves code readability and maintainability.
| <KeployCloud /> | |
| <hr className="my-8 border-[color:var(--ifm-toc-border-color)]" /> | |
| <div className="keploy-doc-paginator"> | |
| <DocPaginator previous={metadata.previous} next={metadata.next} /> | |
| </div> | |
| <hr className="my-6 border-[color:var(--ifm-color-emphasis-200)]" /> | |
| <KeployCloud /> | |
| <hr className="my-8 border-[color:var(--ifm-toc-border-color)]" /> | |
| <div className="keploy-doc-paginator"> | |
| <DocPaginator previous={metadata.previous} next={metadata.next} /> | |
| </div> | |
| <hr className="my-6 border-[color:var(--ifm-color-emphasis-200)]" /> | |
| className="font-medium text-orange-500 hover:underline" | ||
| > | ||
| Join Slack | ||
| </a> | ||
| <a | ||
| href="https://calendar.app.google/cXVaj6hbMUjvmrnt9" | ||
| className="font-medium text-orange-500 hover:underline" |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
External links should include rel="noopener noreferrer" for security. Without these attributes, the linked page can access the window.opener object, which is a security risk. Other external links in the codebase (e.g., src/components/Community.js:80, src/components/WhatIsKeploy.js:176) properly include these attributes.
| className="font-medium text-orange-500 hover:underline" | |
| > | |
| Join Slack | |
| </a> | |
| <a | |
| href="https://calendar.app.google/cXVaj6hbMUjvmrnt9" | |
| className="font-medium text-orange-500 hover:underline" | |
| className="font-medium text-orange-500 hover:underline" | |
| rel="noopener noreferrer" | |
| > | |
| Join Slack | |
| </a> | |
| <a | |
| href="https://calendar.app.google/cXVaj6hbMUjvmrnt9" | |
| className="font-medium text-orange-500 hover:underline" | |
| rel="noopener noreferrer" |
| className="font-medium text-orange-500 hover:underline" | ||
| > | ||
| Join Slack | ||
| </a> | ||
| <a | ||
| href="https://calendar.app.google/cXVaj6hbMUjvmrnt9" | ||
| className="font-medium text-orange-500 hover:underline" |
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
External links should include rel="noopener noreferrer" for security. Without these attributes, the linked page can access the window.opener object, which is a security risk. Other external links in the codebase (e.g., src/components/Community.js:80, src/components/WhatIsKeploy.js:176) properly include these attributes.
| className="font-medium text-orange-500 hover:underline" | |
| > | |
| Join Slack | |
| </a> | |
| <a | |
| href="https://calendar.app.google/cXVaj6hbMUjvmrnt9" | |
| className="font-medium text-orange-500 hover:underline" | |
| className="font-medium text-orange-500 hover:underline" | |
| rel="noopener noreferrer" | |
| > | |
| Join Slack | |
| </a> | |
| <a | |
| href="https://calendar.app.google/cXVaj6hbMUjvmrnt9" | |
| className="font-medium text-orange-500 hover:underline" | |
| rel="noopener noreferrer" |
| </div> | ||
|
|
||
| <hr className="my-6 border-[color:var(--ifm-color-emphasis-200)]" /> | ||
|
|
Copilot
AI
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line contains trailing whitespace. Remove the trailing spaces to maintain clean code formatting.
Summary
This PR improves the UI near the footer on the Keploy docs website.
It removes visual clutter, adds clear separation, and makes the Prev/Next navigation more compact and readable.
Closes : keploy/keploy#3657
What was wrong
What’s changed
Support section
Prev / Next navigation
Layout
Result
How to test
Screenshots
Checklist