AioZipStream does not support async generators

[mojimi]

The following example does not work :

        async def files_generator():
            for filename in ['test1.txt', 'test2.txt', 'test3.txt']:
                yield {
                    'stream': await storage.get_file_stream({'path' : filename}, 5),
                    'name': filename
                }

        zs = AioZipStream(files_generator())

[kbbdy]

Hi. I can't say what's wrong without knowing what is storage.get_file_stream method and what it returns. You also not added any error log, so I can't help. Remember that stream generator should return chunks of binary data.

[kingmad]

@kbbdy AioZipStream does not support async generator as an input. Changing for loop to async for in AioZipStream.stream#78 will probably do the job in this particular case

[kbbdy]

Ok, thanks. I will check that.

[mojimi]

Yes exactly what kingmad said, sorry I should've explained it better.

Basically by not working with an async generator it won't free up memory and/or the asyncio loop in some cases

[ChristianMeisenbichler]

I would also like to use an async iterator for the source of the files list maybe implement a stream_async_iter method ? Something where the loop looping over the files (AioZipStream.stream#78) is async for?