Open
Conversation
cooktheryan
changed the title
cooktheryan
force-pushed
the
fix/openshift-scc-ubi-images
branch
2 times, most recently
from
f2e06b3 to
7eab222
Compare
cooktheryan
changed the title
cooktheryan
force-pushed
the
fix/openshift-scc-ubi-images
branch
from
7eab222 to
d430469
Compare
cwiklik
approved these changes
Mar 27, 2026
Collaborator
cwiklik
left a comment
cwiklik
left a comment
There was a problem hiding this comment.
Review Summary
Solid OpenShift SCC compatibility fix. Correctly rebases images on UBI 9, removes hardcoded UIDs for MustRunAsRange compatibility, changes fsGroup to 0 (OpenShift GID convention), and adds AllowPrivilegeEscalation: false across all sidecars. The spiffe-helper Dockerfile is well-crafted with SHA-pinned builds. All 17 CI checks pass.
Areas reviewed: Dockerfile, Go, Helm values, CI workflow
Commits: 1 commit, signed-off: yes, proper Assisted-By trailer
CI status: All passing (Kind E2E, Trivy, Hadolint, CodeQL, etc.)
…ntext - Dockerfile.envoy: rebase on UBI 9 minimal (SHA-pinned), extract envoy binary from upstream v1.37.1 image, run as UID 1001 - spiffe-helper: new forked Dockerfile on UBI 9 micro (SHA-pinned), built from upstream v0.11.0 source with commit SHA verification - container_builder.go: remove hardcoded runAsUser/runAsGroup from spiffe-helper and client-registration, add allowPrivilegeEscalation=false and runAsNonRoot=true on all sidecars, change SharedVolumesFSGroup to 0 - defaults.go: point spiffe-helper to ghcr.io/kagenti/kagenti-extensions - build.yaml: add spiffe-helper to CI image build matrix - values.yaml: point spiffeHelper to forked image Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Ryan Cook <rcook@redhat.com>
cooktheryan
force-pushed
the
fix/openshift-scc-ubi-images
branch
from
938b6ed to
6f474bb
Compare
Contributor
Author
|
ready for round2 @cwiklik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build required images based on UBI and allow the user to be 1001 and deploy safely