Skip to content

Wiki Feedback #1

@niartenyaw

Description

@niartenyaw

Design Docs Feedback

Great job! Look really good, just a few things. Let me know if you have
any questions about my comments for tags. remember that you must
finish the wiki before you start coding tomorrow.

MVP List

  • Great! Could you add a timeline to your MVPs?

Wireframes & Component Hierarchy

  • Wireframes look good!
  • For the NotesContainer and NotebooksContainer, you will probably
    also have a singular NotesContainer and NotebookContainer, so to
    make it easier on yourself, I would suggest adding List or Index
    into the name. So NotesIndexContainer and NotebooksIndexContainer.

State Shape

  • Be careful nesting lists of ids inside of other slices of state, for
    instance notebooksId: [1]. This means that if a user creates a new
    notebook, you now have to update both the notebooks slice and the
    users slice (to update the list of IDs).

Routes

  • Looks great!

Schema

  • Might want to include a user_id to the notes table
  • For tags, you will want a tags table that will hold the names of
    all of the tags, and then a taggings joins table to connect the tags
    with the notes.

Metadata

Metadata

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions