-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
Description
Design Docs Feedback
Great job! Look really good, just a few things. Let me know if you have
any questions about my comments for tags. remember that you must
finish the wiki before you start coding tomorrow.
MVP List
- Great! Could you add a timeline to your MVPs?
Wireframes & Component Hierarchy
- Wireframes look good!
- For the
NotesContainerandNotebooksContainer, you will probably
also have a singularNotesContainerandNotebookContainer, so to
make it easier on yourself, I would suggest addingListorIndex
into the name. SoNotesIndexContainerandNotebooksIndexContainer.
State Shape
- Be careful nesting lists of ids inside of other slices of state, for
instancenotebooksId: [1]. This means that if a user creates a new
notebook, you now have to update both thenotebooksslice and the
usersslice (to update the list of IDs).
Routes
- Looks great!
Schema
- Might want to include a
user_idto thenotestable - For
tags, you will want atagstable that will hold the names of
all of the tags, and then ataggingsjoins table to connect thetags
with thenotes.