-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
BugSomething isn't workingSomething isn't workingConfigurationFor issues relating to the configuration languageFor issues relating to the configuration languagepriority:highThings that are high priority, but do not warrant an immediate hotfixThings that are high priority, but do not warrant an immediate hotfix
Description
With the following config, ACES yielded prediction_times corresponding to the start of the input window instead of the end as specified by the index_timestamp argument. Here is my conversation with codex about it -- it's suggestion for redefining the input window boundaries did indeed yield prediction times at the end of the input window. Below is the input window config which lead to the bug. Will have to investigate further in the future how to fix this in ACES.
trigger: cxr
windows:
input:
start: end - 24h
end: trigger
index_timestamp: end
start_inclusive: True
end_inclusive: True
index_timestamp: end
has:
_ANY_EVENT: (5, None)
target:
start: input.end
end: start + 1h
start_inclusive: False
end_inclusive: True
label: pneumonia
Here is the suggested refactor of the input window which yielded correct prediction_times at the end of the window:
windows:
input:
start: trigger - 24h
end: start + 24h
start_inclusive: True
end_inclusive: True
index_timestamp: end
has:
_ANY_EVENT: (5, None)
target:
start: input.end
end: start + 1h
start_inclusive: False
end_inclusive: True
label: pneumonia
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugSomething isn't workingSomething isn't workingConfigurationFor issues relating to the configuration languageFor issues relating to the configuration languagepriority:highThings that are high priority, but do not warrant an immediate hotfixThings that are high priority, but do not warrant an immediate hotfix