update workflow job steps

Author: itsharshvb

.github/workflows/api-compatibility.yml

@@ -1,5 +1,8 @@
 name: API Schema Compatibility Check
 
+permissions:
+  contents: read
+
 # This workflow:
 # - Runs on ALL PRs that modify API-related files
 # - Always fails if breaking changes are detected
@@ -47,55 +50,17 @@ jobs:
           go install github.com/oasdiff/oasdiff@v1.11.7
           echo "$HOME/go/bin" >> $GITHUB_PATH
 
-      - name: Use committed API schemas
+      - name: Prepare PR schemas
         run: |
-          echo "Using OpenAPI schemas from PR (generated by validate-openapi-spec workflow)..."
-
-          # Verify schemas exist (they should be committed by validate-openapi-spec workflow)
-          if [[ ! -f "api-reference/v1/openapi_spec_v1.json" ]]; then
-            echo "::error::V1 schema not found. The validate-openapi-spec workflow should have generated it."
-            exit 1
-          fi
-
-          if [[ ! -f "api-reference/v2/openapi_spec_v2.json" ]]; then
-            echo "::error::V2 schema not found. The validate-openapi-spec workflow should have generated it."
-            exit 1
-          fi
-
-          # Validate JSON format
-          if ! jq empty api-reference/v1/openapi_spec_v1.json 2>/dev/null; then
-            echo "::error::V1 schema contains invalid JSON"
-            exit 1
-          fi
-
-          if ! jq empty api-reference/v2/openapi_spec_v2.json 2>/dev/null; then
-            echo "::error::V2 schema contains invalid JSON"
-            exit 1
-          fi
-
-          # Copy to working files
-          cp api-reference/v1/openapi_spec_v1.json pr-v1-schema.json
-          cp api-reference/v2/openapi_spec_v2.json pr-v2-schema.json
-
-          echo "V1 schema: $(wc -c < pr-v1-schema.json) bytes"
-          echo "V2 schema: $(wc -c < pr-v2-schema.json) bytes"
+          jq empty api-reference/v1/openapi_spec_v1.json && cp api-reference/v1/openapi_spec_v1.json pr-v1-schema.json || { echo "::error::V1 schema invalid or missing"; exit 1; }
+          jq empty api-reference/v2/openapi_spec_v2.json && cp api-reference/v2/openapi_spec_v2.json pr-v2-schema.json || { echo "::error::V2 schema invalid or missing"; exit 1; }
 
       - name: Extract base branch schemas
         env:
-          BASE_REF: ${{ github.event.pull_request.base.ref }}
           BASE_SHA: ${{ github.event.pull_request.base.sha }}
         run: |
-          if git show "$BASE_SHA:api-reference/v1/openapi_spec_v1.json" > base-v1-schema.json 2>/dev/null; then
-            echo "V1 schema extracted from $BASE_REF"
-          else
-            echo "{}" > base-v1-schema.json
-          fi
-
-          if git show "$BASE_SHA:api-reference/v2/openapi_spec_v2.json" > base-v2-schema.json 2>/dev/null; then
-            echo "V2 schema extracted from $BASE_REF"
-          else
-            echo "{}" > base-v2-schema.json
-          fi
+          git show "$BASE_SHA:api-reference/v1/openapi_spec_v1.json" > base-v1-schema.json 2>/dev/null || echo "{}" > base-v1-schema.json
+          git show "$BASE_SHA:api-reference/v2/openapi_spec_v2.json" > base-v2-schema.json 2>/dev/null || echo "{}" > base-v2-schema.json
 
       - name: Run breaking change detection
         id: breaking_changes
@@ -156,30 +121,8 @@ jobs:
         run: |
           echo "::error::Breaking changes detected in API schema."
           echo "::error::Found ${{ steps.breaking_changes.outputs.breaking_changes }} breaking change(s)."
-          echo "::error::Please review the compatibility report and consider:"
-          echo "::error::- Creating a new API version (v3)"
-          echo "::error::- Using backward-compatible changes instead"
-          echo "::error::- Coordinating with API consumers before deployment"
           exit 1
 
-      - name: Upload validation artifacts
-        if: always()
-        uses: actions/upload-artifact@v4
-        with:
-          name: api-validation-artifacts-${{ github.run_number }}
-          path: |
-            pr-v1-schema.json
-            pr-v2-schema.json
-            base-v1-schema.json
-            base-v2-schema.json
-            v1-breaking-report.txt
-            v2-breaking-report.txt
-            v1-detailed-diff.txt
-            v2-detailed-diff.txt
-            v1-breaking-status.txt
-            v2-breaking-status.txt
-          retention-days: 30
-
   migration-compatibility-check:
     name: Migration Breaking Change Detection
     runs-on: ubuntu-latest