Submitting Homework for CoderSchool VN

[jundalisay]

Here is my homework

/cc @coderschoolreview

[coderschoolreview]

Thank you for your Rails submission, jundalisay!

😋 Everything looks good with the format of your submission. We'll be reviewing your submission soon!

[hoksilato]

Hi @jundalisay

Thanks for your submitting. Good work 👍.

In summary, your submission is good. Great job with the React version. And well done with case insensitive searching. I saw you used impressionist gem for increasing article's views, it's clever.

Below are some suggestions that can improve your app:

• Articles should be displaying with created_at descending order.
• You should render article's title with RedCarpet if you allow using Markdown, but it's not recommended because it may break your layout.
• You should not allow users to update and delete the article about yourself.
• You can set root path to articles#index, no need to create site_controller.rb.
• You can improve your blog UI with some Bootstrap 4 examples.
• For the better performance and UX, you can use kaminari gem for pagination.
• I don't know why you remove your article validations. Always be cautious with user input, you can view more detail at Active Record Validations.

Let us know if you have any questions.

/cc @coderschoolreview @harley

[jundalisay]

Thanks for the suggestions @hoksilato. I'll do them over the weekend. I use site_controller for the react version (making it 2 UIs in one app) and removed the validations to see what null entries would do and how they would look. This week, I'll try to use react for the search functionality instead of using the rails controller.

[hoksilato]

Thanks for your reply @jundalisay but if you can, please update with the easy ones first because the deadline is tomorrow (1st March).