Fixed memory out of bounds accesses and added more debug options for address sanitizer

Author: julecko

CMakeLists.txt

@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.10)
 project(njam C)
 
-set(NJAM_VERSION "2.0.3")
+set(NJAM_VERSION "2.0.4")
 
 set(CMAKE_C_STANDARD 99)
 set(CMAKE_C_STANDARD_REQUIRED ON)
@@ -20,12 +20,14 @@ set(CMAKE_INTERPROCEDURAL_OPTIMIZATION TRUE)
 # Debug/Release compiler flags
 if(CMAKE_BUILD_TYPE STREQUAL "Debug")
     add_compile_definitions(DEBUG_MODE=1)
-    add_compile_options(-g -O0)
+    add_compile_options(-g -O0 -fsanitize=address -fno-omit-frame-pointer)
+    add_link_options(-fsanitize=address)
 else()
     add_compile_definitions(NDEBUG)
     add_compile_options(-O3)
 endif()
 
+
 # Executable 1: njam
 add_executable(njam
     src/main.c

src/network.c

@@ -108,7 +108,7 @@ size_t network_count_inactive(const Network network) {
     }
 
     size_t counter = 0;
-    for (size_t i = 0; i <= network.device_count; i++) {
+    for (size_t i = 0; i < network.device_count; i++) {
         if (network.devices[i].status == INACTIVE) {
             counter++;
         }
@@ -117,14 +117,14 @@ size_t network_count_inactive(const Network network) {
 }
 
 void network_set_dead(Network network) {
-    for (size_t i = 0;i<=network.device_count;i++) {
+    for (size_t i = 0;i < network.device_count;i++) {
         network.devices[i].alive = false;
     }
 }
 
 size_t network_count_alive_or_jammed(Network network) {
     size_t counter = 0;
-    for (size_t i = 0;i<=network.device_count;i++) {
+    for (size_t i = 0;i < network.device_count;i++) {
         if (network.devices[i].alive || network.devices[i].status == JAMMING || network.devices[i].status == DISCONNECTING) {
             counter++;
         }
@@ -164,7 +164,7 @@ DeviceGroup print_network_nice(Network network, size_t offset, size_t max_visibl
     printf(" %3s  %-15s  %-17s  %-6s  %-7s\n", "ID", "IP", "MAC", "Alive", "Jamming");
     printf("───────────────────────────────────────────────────────────────\n");
 
-    for (size_t i = 0; i <= network.device_count; i++) {
+    for (size_t i = 0; i < network.device_count; i++) {
         if (network.devices[i].alive || network.devices[i].status == JAMMING || network.devices[i].status == DISCONNECTING) {
             group.devices[idx++] = &network.devices[i];
         }