Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Github token without repo:public_repo OAuth scope causes 404 for loader files only #114

@webxl

Description

@webxl

The cache makes this a bit hard to test, so rm -rf ~/.jspm/loader-files/systemjs before testing.

First off, I think the config command gives false positives. This was using a key without repo:public_repo:

$ jspm registry config github
Would you like to set up your GitHub credentials? [yes]:
     If using two-factor authentication or to avoid using your password you can generate an access token at https://github.com/settings/tokens. Ensure it has public_repo scope access.

Enter your GitHub username:webxl
Enter your GitHub password or access token:
Would you like to test these credentials? [yes]:
ok   GitHub authentication is working successfully.
ok   Registry github configured successfully.

I think it also was successful putting in garbage credentials, but something could have been cached in my config I suppose. But whenever the loader files are needed, it chokes with 404:

$ jspm init

ok   Verified package.json at package.json
     Verified config file at config.js
     Looking up loader files...

warn Error on download for github:systemjs/systemjs
     Bad response code 404

err

err  Error downloading loader files.

err

Originally I got this by running jspm install against this project: https://github.com/css-modules/jspm-demo. It was able to load dependencies from github, so I think this scope might only be required when the loader files are needed.

Also, it would be great if the error message contained info about the repo:public_repo scope.

Using jspm v0.16.49

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions