Trimming whitespace on save results in additional unsaved changes

[thecodemill]

It looks as though the trim is taking place AFTER saving, instead of BEFORE. This means whenever the plugin removes whitespace during a save, it immediately creates further unsaved changes on the file and I effectively have to save twice. That, or dismiss the "Save before closing?" prompt when closing the file.

[jsmecham]

Interesting, this must be a regression in v1.3.0. I will take a look at it. Thanks for the report!

[ConnectGrid]

I had just posted this issue here #7 , but I've since closed that issue to avoid a duplicate. Any chance of this issue being resolved soon? It's been several months now since you became aware of it.

Greatly appreciate your time.

[ConnectGrid]

Could the bug be caused by asynchronous behaviour? A timing issue?

"onWillSave" is being used, but the actual trimming is happening after the save, causing the document to be edited again.

nova-whitespace/Source/Scripts/main.js

Line 18 in 7aa6f81

return editor.onWillSave(whitespace.maybeTrimTrailingWhitespace.bind(whitespace));

[freinbichler]

I have the same issue. Took me a while to figure out that this plugin was the reason I often have to save twice. If this could be fixed I would highly appreciate it!

[MSchmidt]

Same here. Would also highly appreciate a fix.

[jsmecham]

I'm no longer seeing this on Nova 2, can you try and see if it is fixed for you?

[freinbichler]

I can confirm that it is working in Nova 2 🙌

[ConnectGrid]

I, too, have not been bothered by this issue lately, so it must've been fixed.

Was this a bug in Nova itself that was eventually resolved? That would explain why the bug first appeared in the first place, too.

[SamGoody]

I find that on local files, it saves correctly. But on remote (SFTP) files, I have to save twice.

Am not sure if this is the same issue, and local files just save fast enought o avoid it, or another issue.

[ConnectGrid]

I believe this issue was actually a Nova bug because it no longer happens, even though this extension has not been updated by the author in 10 months.

[GwynethLlewelyn]

I believe this issue was actually a Nova bug because it no longer happens, even though this extension has not been updated by the author in 10 months.

... and it's not really required any longer, just use .editorconfig — Nova now fully supports it natively, so there is no point in having an extra extension to do essentially the same.